WIP: Add Constraints 131, 133, 134 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 10, 2023 17:29
* Add docs * change `ValueError` to `AASConstraintViolation` * Add check to constructor
Add Constraint to docs
Compare all `idShort`s in the constructor. Set lists of variables private and check constraint when alternating lists. Add Unittest
attribute `specific_asset_id` is now also private and checks constraint AASd-131 when being set.
…t AASd-131 The new implemented Constraints AASd-131 enforces, that either `globalAssetId` or `specificAssetId` is defined.
… AASd-134. Constraint AASd-134 enforces, that all idShorts of input-/output-/inoutput-Variable/value are unique.
…ial_serialization_deserialization.py` to adapt to Constraint AASd-131. Constraint AASd-131 enforces, that at least `globalAssetId` or `specificAssetId` is defined.
…py` and `json_deserialization.py` to adapt to Constraint AASd-131 Both methods create the `asset_information` object with the `globalAssetId` and `specificAssetId` instead of adding both afterward. This is important, because else AASd-131 is raised.
…to create set of all `specific_asset_ids`
dxvidnrt
changed the title
added 4 commits
June 30, 2023 12:11
…setInformation` without `global_asset_id` and `specific_asset_id` Version 3.0 introduces new Constraint AASd-131 that prohibits the creation of `AssetInformation`-objects, where `global_asset_id` and `specific_asset_id` are None. Therefore, xml-/json-files that do so are adapted.
… in `test_xml_deserialization.py` or `test_json_deserialization.py` Version 3.0 adds the Constraint AASd-131, that enforces `assetInformation`-objects to contain at least a `global_asset_id` or `specific_asset_id`
…ibutes.py` and `example_submodel_template.py` Version 3.0 introduces a new Constraint that enforces all `OperationVariable`'s in one `Operation` element to have different `idShort`'s for their `value`
|
@s-heppner
I was not able to resolve all errors in the XML, JSON and AASX files that are occurring because they are working with the above described objects. @s-heppner Can you assign someone to this PR? |
|
|
We decided to implement them as separate PRs rather than this large one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the new constraints of Version 3.0:
AASd-131: Has no Unittest yet, because there is no such file
test_aas.pyand the constraint is inaas.pyAASd-133: The constraint is added, there are no changes to the code, because our implementation already uses
GlobalReferenceinstead ofReference.see: https://industrialdigitaltwin.org/wp-content/uploads/2023/04/IDTA-01001-3-0_SpecificationAssetAdministrationShell_Part1_Metamodel.pdf#Page=168