Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable containerized build of integrated scenario #81

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

ladatz
Copy link
Contributor

@ladatz ladatz commented Mar 5, 2024

Closes #80

Motivation and Context

Today we have the configuration and Dockerfiles in order to build Agemo in standalone mode. Enable a containerized build of Agemo integrated with Chariott service discovery.
This also helps for building scenarios (like the Software Orchestration blueprint) which leverage Chariott and Agemo together.

Description

  • Add Dockerfile_integrated for both target architectures to containerize Agemo integrated with Chariott Service Discovery
  • Add a configuration for "integrated" mode where Agemo uses Chariott Service Discovery
  • Remove Cargo.lock from dockerignore. We don't have it in a gitignore, and it is recommended to include it to have deterministic builds.

devkelley
devkelley previously approved these changes Mar 5, 2024
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

Dockerfile_integrated.amd64 Outdated Show resolved Hide resolved
Dockerfile_integrated.arm64 Show resolved Hide resolved
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ladatz ladatz merged commit be46d9c into main Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PBI] Enable containerized build of Agemo integrated with Chariott
3 participants