fix: Unexpected error message No IDE URL after 20 sec during workspac…

…e startup (#1207)

* fix: StartingStepOpenWorkspace render

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* fixup! fix: StartingStepOpenWorkspace render

Signed-off-by: Oleksii Orel <oorel@redhat.com>

---------

Signed-off-by: Oleksii Orel <oorel@redhat.com>

packages/dashboard-frontend/src/components/WorkspaceProgress/StartingSteps/OpenWorkspace/__tests__/index.spec.tsx

@@ -391,6 +391,29 @@ describe('Starting steps, opening an editor', () => {
         .build();
     });
 
+    test('should not show notification alert if STARTING', async () => {
+      store = new FakeStoreBuilder()
+        .withDevWorkspaces({
+          workspaces: [
+            new DevWorkspaceBuilder()
+              .withName(workspaceName)
+              .withNamespace(namespace)
+              .withStatus({ phase: 'STARTING' })
+              .build(),
+          ],
+        })
+        .build();
+      renderComponent(store);
+      jest.runAllTimers();
+
+      // trigger timeout
+      const timeoutButton = screen.queryByRole('button', {
+        name: 'onTimeout',
+      });
+      expect(timeoutButton).toBeNull();
+      expect(mockOnError).not.toHaveBeenCalled();
+    });
+
     test('notification alert', async () => {
       renderComponent(store);
       jest.runAllTimers();

packages/dashboard-frontend/src/components/WorkspaceProgress/StartingSteps/OpenWorkspace/index.tsx

@@ -234,7 +234,11 @@ class StartingStepOpenWorkspace extends ProgressStep<Props, State> {
     const { distance, hasChildren } = this.props;
     const { name, lastError } = this.state;
 
-    const isActive = distance === 0;
+    // status may flicker from starting to running and back to starting
+    // but we need to run the timer only when the workspace is running
+    const workspace = this.findTargetWorkspace(this.props);
+    const isActive = workspace?.isRunning && distance === 0;
+
     const isError = false;
     const isWarning = lastError !== undefined;