Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hasTechPreviewTag filter #1205

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix: hasTechPreviewTag filter #1205

merged 3 commits into from
Sep 30, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 27, 2024

What does this PR do?

Fix hasTechPreviewTag filter.

Screenshot/screencast of this PR

Знімок екрана 2024-09-30 о 14 53 05

Знімок екрана 2024-09-30 о 14 53 32

What issues does this PR fix or reference?

fixes eclipse-che/che#23161

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open Create Workspace page on the dashboard.
  3. Open Editor Selector/Choose an Editor.
  4. Choose insiders tag for VS Code.
  5. All editors should have a Tech Preview label.

Release Notes

Docs PR

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1205

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1205", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1205

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1205", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1205

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1205", name: che-dashboard}]}}]"

@eclipse-che eclipse-che deleted a comment from codecov bot Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (d48136f) to head (aac97d8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   91.35%   89.94%   -1.41%     
==========================================
  Files         442      443       +1     
  Lines       45650    45675      +25     
  Branches     3044     3067      +23     
==========================================
- Hits        41704    41083     -621     
- Misses       3946     4554     +608     
- Partials        0       38      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibuziuk
Copy link
Member

ibuziuk commented Sep 30, 2024

@olexii4 please, backport to 7.92.x once merged

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 5c42201 into main Sep 30, 2024
20 of 21 checks passed
@olexii4 olexii4 deleted the CHE-23161 branch September 30, 2024 18:03
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.x/558: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

olexii4 added a commit that referenced this pull request Oct 1, 2024
* fix: hasTechPreviewTag filter

Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4 added a commit that referenced this pull request Oct 2, 2024
… message No IDE URL (#1209)

* fix: hasTechPreviewTag filter (#1205)

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* fix: Unexpected error message No IDE URL after 20 sec during workspace startup (#1207)

Signed-off-by: Oleksii Orel <oorel@redhat.com>

---------

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/559: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/559: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7768 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7779: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 64745659 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard should show an editor's tags
5 participants