Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade CodeMirror to v6 #1245

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: Upgrade CodeMirror to v6 #1245

merged 1 commit into from
Nov 6, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 1, 2024

What does this PR do?

Upgrade CodeMirror to v6.

Screenshot/screencast of this PR

Знімок екрана 2024-11-06 о 01 09 42

What issues does this PR fix or reference?

fixes eclipse-che/che#23220

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Create a new workspace.
  3. Open Workspace Detail/Devfile.
  4. Devfile Viewer should be shown.

Release Notes

Docs PR

Copy link

openshift-ci bot commented Nov 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Nov 1, 2024

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 78.48101% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (3d3945d) to head (845266c).

Files with missing lines Patch % Lines
...rd-frontend/src/components/DevfileViewer/index.tsx 75.36% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         445      445           
  Lines       46094    46138   +44     
  Branches     3129     3127    -2     
=======================================
+ Hits        41527    41570   +43     
- Misses       4531     4532    +1     
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4 olexii4 marked this pull request as ready for review November 5, 2024 23:20
@olexii4 olexii4 changed the title [wip] chore: upgrade dashboard codemirror [wip] chore: Upgrade CodeMirror to v6 Nov 5, 2024
@olexii4 olexii4 changed the title [wip] chore: Upgrade CodeMirror to v6 chore: Upgrade CodeMirror to v6 Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1245

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1245", name: che-dashboard}]}}]"

@olexii4 olexii4 force-pushed the CHE-23220 branch 2 times, most recently from df6de4a to 845266c Compare November 6, 2024 07:05
Copy link

github-actions bot commented Nov 6, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1245

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1245", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

github-actions bot commented Nov 6, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1245

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1245", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 561fad8 into main Nov 6, 2024
18 of 19 checks passed
@olexii4 olexii4 deleted the CHE-23220 branch November 6, 2024 15:02
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/586: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dashboard codemirror
5 participants