Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor selector cards #1246

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix editor selector cards #1246

merged 1 commit into from
Nov 4, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 1, 2024

What does this PR do?

This PR fixes UI for Editor Selector cards:

  • align the editor provider text (Provided by ...) to the same line - bottom of tile
  • clicking on the links (Jet Brains, License) will open a page in a new browser's tab
  • editor dropdown will show the deprecated ones at the end of the list

Screenshot/screencast of this PR

Знімок екрана 2024-11-02 о 00 32 09

What issues does this PR fix or reference?

fixes eclipse-che/che#23222

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open Create Workspace page on the dashboard and Choose an EDitor.
  3. Check on the editor provider text (Provided by ...) in the bottom.
  4. Click on the links (Jet Brains, License) should open a page in a new browser's tab.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Nov 1, 2024

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested a review from azatsarynnyy November 1, 2024 05:30
Copy link

github-actions bot commented Nov 1, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1246

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1246", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Nov 1, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1246

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1246", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.07%. Comparing base (bd75e93) to head (c496147).

Files with missing lines Patch % Lines
.../components/EditorSelector/Gallery/Entry/index.tsx 77.77% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   89.95%   90.07%   +0.12%     
==========================================
  Files         445      445              
  Lines       46043    46079      +36     
  Branches     3113     3124      +11     
==========================================
+ Hits        41418    41507      +89     
+ Misses       4588     4536      -52     
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1246

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1246", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Nov 1, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1246

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1246", name: che-dashboard}]}}]"

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Thanks @olexii4

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

github-actions bot commented Nov 1, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1246

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1246", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Nov 1, 2024

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-e2e-puppeteer 2745f0c link true /test v14-e2e-puppeteer
ci/prow/v14-dashboard-happy-path 2745f0c link true /test v14-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, azatsarynnyy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member

ibuziuk commented Nov 4, 2024

cc: @dmytro-ndp I think we should consider backporting to 7.92.x once merged

@olexii4 olexii4 merged commit 0572a10 into main Nov 4, 2024
17 of 19 checks passed
@olexii4 olexii4 deleted the CHE-23222 branch November 4, 2024 14:15
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/584: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX enhancements of the editor tiles
6 participants