-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'experimental' placeholder to the passphrase #1249
Conversation
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1249 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1249", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, IMHO
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 90.09% 89.94% -0.15%
==========================================
Files 445 445
Lines 46094 46094
Branches 3129 3097 -32
==========================================
- Hits 41527 41458 -69
- Misses 4531 4598 +67
- Partials 36 38 +2 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the discussion we agreed only to mark the injection of the SSH agent postStart event as experimental. The SSH agent post start event is needed only for the SSH flow from terminal, so disabling the particular feature will not affect the rest ssh features e.g. start workspace from ssh url or git remote operations from che-code. So I would rather add some documentation regarding the SSH flow from terminal e.g. we need to enable DWO experimental features to have this feature.
What does this PR do?
See devfile/devworkspace-operator#1337 (comment)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Related to devfile/devworkspace-operator#1337
Is it tested? How?
Release Notes
Docs PR