Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'experimental' placeholder to the passphrase #1249

Closed
wants to merge 2 commits into from
Closed

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Nov 5, 2024

What does this PR do?

See devfile/devworkspace-operator#1337 (comment)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Related to devfile/devworkspace-operator#1337

Is it tested? How?

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Nov 5, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Copy link

github-actions bot commented Nov 5, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1249

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1249", name: che-dashboard}]}}]"

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, IMHO

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (3d3945d) to head (14bfb6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   90.09%   89.94%   -0.15%     
==========================================
  Files         445      445              
  Lines       46094    46094              
  Branches     3129     3097      -32     
==========================================
- Hits        41527    41458      -69     
- Misses       4531     4598      +67     
- Partials       36       38       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the discussion we agreed only to mark the injection of the SSH agent postStart event as experimental. The SSH agent post start event is needed only for the SSH flow from terminal, so disabling the particular feature will not affect the rest ssh features e.g. start workspace from ssh url or git remote operations from che-code. So I would rather add some documentation regarding the SSH flow from terminal e.g. we need to enable DWO experimental features to have this feature.

@openshift-ci openshift-ci bot removed the lgtm label Nov 6, 2024
@ibuziuk ibuziuk closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants