Improve the Devfile is not reachable warning for SSH urls #1259
Conversation
vinokurig
requested review from
akurinnoy,
olexii4 and
ibuziuk
as code owners
|
Click here to review and test in web IDE: |
vinokurig
force-pushed
the
CRW-7624
branch
2 times, most recently
from
72b72a2 to
b344e5b
Compare
|
@vinokurig please take a look at the failed unit test |
| <ExpandableWarning | ||
| textBefore="Devfile resolve from a privatre repositry via an SSH url is not supported." | ||
| errorMessage="Could not reach devfile" | ||
| textAfter="You can apply a Personal Access Token to be able to fetch the devfile.yaml content." |
There was a problem hiding this comment.
if applying PAT solves the issue, I'd change the wording to this:
"Apply a Personal Access Token to fetch the devfile.yaml content."
|
@vinokurig : could you, please, take a look at the failing build https://github.com/eclipse-che/che-dashboard/actions/runs/11916044763/job/33207772337 ? It prevents building dashboard image quay.io/eclipse/che-dashboard:pr-1259 needed to verify PR changes. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1259 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1259", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 91.65% 91.73% +0.07%
==========================================
Files 497 497
Lines 45446 45494 +48
Branches 3169 3171 +2
==========================================
+ Hits 41654 41734 +80
+ Misses 3762 3729 -33
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -83,6 +84,8 @@ export const BRANDING_DEFAULT: BrandingData = { | |||
| 'https://www.eclipse.org/che/docs/stable/end-user-guide/url-parameter-for-the-workspace-storage/', | |||
| webSocketTroubleshooting: | |||
| 'https://www.eclipse.org/che/docs/stable/end-user-guide/troubleshooting-network-problems/', | |||
| startingAWorkspaceFromAGitRepositoryURL: | |||
There was a problem hiding this comment.
Few remarks:
- Variable name could be simplified and not linked to docs article name, which could be changed in future; e.g.
startWorkspaceFromGit - Don't forget to add downstream documentation URL for
startingAWorkspaceFromAGitRepositoryURLinto the product.json: https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/devspaces-dashboard/packages/dashboard-frontend/assets/branding/product.json#L21
There was a problem hiding this comment.
Done, pull request for the downstream: redhat-developer/devspaces-images#658
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1259 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1259", name: che-dashboard}]}}]" |
|
@vinokurig: the PR validated successfully using DS 3.17.0.RC-58 + dashboard deployed from quay.io/eclipse/che-dashboard:pr-1259. Checked links by creating workspace using SSH URL of private repo having SSH key with and without passphrase added to the User Preferences:
Public repo opened successfully from SSH URL. There were no any warnings at start workspace page. Well done! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.18 :: dashboard_3.x/592: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8119: Console, Changes, Git Data |
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8196: dashboard : 3.x :: Failed in 65968155 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7624
Is it tested? How?
User Preferences->SSH KeysSee: the workspace start interrupts with the warning:
A new documentation link is added to the warning.
Release Notes
Docs PR