Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/nodejs-18:1-133 to ubi8/nodejs-18:1-133.1731463548 #1264

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Nov 23, 2024

Signed-off-by: Nick Boldt nboldt@redhat.com

…63548

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci-robot
Copy link

@che-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt nboldt@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@che-bot
Copy link
Contributor Author

che-bot commented Nov 23, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1264

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1264", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (e93269b) to head (6e8db08).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   91.67%   91.59%   -0.08%     
==========================================
  Files         497      497              
  Lines       45494    45494              
  Branches     3172     3171       -1     
==========================================
- Hits        41705    41672      -33     
- Misses       3757     3791      +34     
+ Partials       32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, che-bot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 930cd8a into main Nov 26, 2024
20 of 21 checks passed
@akurinnoy akurinnoy deleted the pr-update-base-images-1732320312 branch November 26, 2024 10:18
@devspacesbuild
Copy link

Build 3.18 :: dashboard_3.x/596: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/8242: FAILURE

dashboard : 3.x :: Failed in 66027479 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants