Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the ssh url pattern check #1268

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Extend the ssh url pattern check #1268

merged 1 commit into from
Dec 2, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 28, 2024

What does this PR do?

Add missing ssh patterns to the SSH url check, see https://git-scm.com/docs/git-clone#_git_urls

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23268

Is it tested? How?

  1. Apply the pull request image: quay.io/eclipse/che-dashboard:pr-1268
  2. Add an SSH key to the user namespace and to a bitbucket server instance.
  3. Start a workspace from an SSH url of a private bitbucket server repository.

See: workspace start interrupts with the specific message:
screenshot-cluster-admin-che-dashboard-local-server_apps_rosa_yz5n8-rzhzt-sum_vjy8_p3_openshiftapps_com-2024_11_19-13_20_31

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Nov 28, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1268

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1268", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (930cd8a) to head (22c8a44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files         497      497              
  Lines       45501    45503       +2     
  Branches     3163     3162       -1     
==========================================
- Hits        41651    41644       -7     
- Misses       3820     3829       +9     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1268 - the functionality works properly

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit b7e3a3d into main Dec 2, 2024
18 of 21 checks passed
@vinokurig vinokurig deleted the che-23268 branch December 2, 2024 11:08
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/597: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8286: FAILURE

dashboard : 3.x :: Failed in 66074959 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factory from bitbucket server private repository based on SSH Url has an unexpected warning
5 participants