-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the ssh url pattern check #1268
Conversation
…er>/<path-to-git-repo> format
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1268 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1268", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 91.53% 91.51% -0.02%
==========================================
Files 497 497
Lines 45501 45503 +2
Branches 3163 3162 -1
==========================================
- Hits 41651 41644 -7
- Misses 3820 3829 +9
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Verified on Eclipse Che with |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/597: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8208: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8286: dashboard : 3.x :: Failed in 66074959 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Add missing ssh patterns to the SSH url check, see https://git-scm.com/docs/git-clone#_git_urls
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23268
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1268
See: workspace start interrupts with the specific message:
Release Notes
Docs PR