-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isOauth boolean parameter to the PersonalAccessToken type #1269
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1269 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1269", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
- Coverage 91.53% 91.43% -0.10%
==========================================
Files 497 497
Lines 45501 45478 -23
Branches 3163 3161 -2
==========================================
- Hits 41651 41585 -66
- Misses 3820 3863 +43
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Verified on Eclipse Che with |
packages/dashboard-frontend/src/store/GitOauthConfig/__tests__/actions.spec.ts
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…/actions.spec.ts Co-authored-by: Oleksii Kurinnyi <okurinny@redhat.com>
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1269 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1269", name: che-dashboard}]}}]" |
Build 3.19 :: dashboard_3.x/598: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8209: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8287: dashboard : 3.x :: Failed in 66077195 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Add
isOauth
boolean parameter to thePersonalAccessToken
type to be able to filter tokens that was generated from oAuth. ThetokenName
parameter does not work for this case, because it is set from the original kubernetes secret object name, but not from theche.eclipse.org/scm-personal-access-token-name
label.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23241
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1269
User Preferences
->Personal Access Tokens
tab and add a GitHub PAT.User Preferences
->Git Services
tab and see that the GitHub authorisation is present but the authorisation status is empty and the kebab icon is disabled.Release Notes
With this fix all git services items will have the authorized status, only if a related oAuth token was generated, but not with a manually added Personal Access Token.
Docs PR