-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the GettingStarted samples route #920
Conversation
Signed-off-by: olexii4 <oorel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we backport it to 7.74.x for 3.9 ?
I don't think that we should backport it to 7.74.x for 3.9. It affected just local run on dogfooding. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-920 |
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Build 3.10 :: dashboard_3.x/327: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4510: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4308: dashboard : 3.x :: |
What does this PR do?
This PR Fixes the GettingStarted samples route for local runs for dogfooding.
What issues does this PR fix or reference?
eclipse-che/che#22243
We faced an error during the start of local runs from the main branch with dogfooding instance.
Is it tested? How?
https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/dashboard/#/load-factory?url=https://github.com/eclipse-che/che-dashboard/tree/quick_fixes