Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the GettingStarted samples route #920

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix the GettingStarted samples route #920

merged 1 commit into from
Sep 12, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 12, 2023

What does this PR do?

This PR Fixes the GettingStarted samples route for local runs for dogfooding.

What issues does this PR fix or reference?

eclipse-che/che#22243

We faced an error during the start of local runs from the main branch with dogfooding instance.
Знімок екрана 2023-09-11 о 16 19 45
Знімок екрана 2023-09-11 о 16 49 22

Is it tested? How?

  1. Create a new workspace with https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/dashboard/#/load-factory?url=https://github.com/eclipse-che/che-dashboard/tree/quick_fixes
  2. Execute the command
yarn install --non-interactive && yarn build && oc project dogfooding && export CHE_NAMESPACE='dogfooding' && export NAMESPACE='dogfooding' && yarn start:prepare && yarn start -c
  1. Local runs should start without errors.

Signed-off-by: olexii4 <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2023

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested a review from tolusha September 12, 2023 11:58
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we backport it to 7.74.x for 3.9 ?

@olexii4
Copy link
Contributor Author

olexii4 commented Sep 12, 2023

should we backport it to 7.74.x for 3.9 ?

I don't think that we should backport it to 7.74.x for 3.9. It affected just local run on dogfooding.

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-920

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path f450f49 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4 olexii4 merged commit 7ce1a33 into main Sep 12, 2023
10 checks passed
@olexii4 olexii4 deleted the quick_fixes branch September 12, 2023 12:52
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/327: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4308: FAILURE

dashboard : 3.x ::
; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants