Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative links #923

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix relative links #923

merged 1 commit into from
Sep 18, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 15, 2023

What does this PR do?

Fix relative links for samples.

What issues does this PR fix or reference?

fixes eclipse-che/che#22515

Is it tested? How?

  1. Deploy Eclipse CHE.
  2. Open Create Workspace.
  3. Create a new workspace from the samples from che-devfile-registry with IntelliJ IDEA.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from svor September 15, 2023 16:24
@che-bot
Copy link
Contributor

che-bot commented Sep 15, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-923

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-images 3bcd85f link true /test v11-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
screenshot-nimbusweb me-2023 09 18-10_23_20

After the merge, we have to backport these changes into 7.74.x. Downstream issue: https://issues.redhat.com/browse/CRW-4853

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 5b65006 into main Sep 18, 2023
10 checks passed
@olexii4 olexii4 deleted the CHE-22515 branch September 18, 2023 08:12
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/332: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/333: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@olexii4 olexii4 mentioned this pull request Sep 18, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/332: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4619 triggered

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/333: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4620 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1892: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4621: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4414 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2050: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4621 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1356: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4300: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2050 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4301: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1356: SUCCESS

3.10.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] CHE samples can't start with IntelliJ IDEA
5 participants