Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error code query parameter on workspace create step #932

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Parse error code query parameter on workspace create step, in order to fix bugs:

What issues does this PR fix or reference?

eclipse-che/che#22499
eclipse-che/che#22539

Is it tested? How?

  1. Setup the GitHub Oauth
  2. Start a workspace from a public GitHub repository.
  3. Dashboard redirects to the authentication page, reject it.

See: workspace starts without asking the authentication again.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-932

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #932 (3e1e348) into main (35ffbe2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   82.58%   82.59%           
=======================================
  Files         365      365           
  Lines       37899    37905    +6     
  Branches     2412     2413    +1     
=======================================
+ Hits        31300    31306    +6     
  Misses       6575     6575           
  Partials       24       24           
Flag Coverage Δ
unittests 82.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/common/src/index.ts 100.00% <100.00%> (ø)
...rd-backend/src/routes/factoryAcceptanceRedirect.ts 100.00% <100.00%> (ø)

Signed-off-by: Igor <ivinokur@redhat.com>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-932

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-932

@artaleks9
Copy link
Contributor

Verified on Che deployed with

quay.io/eclipse/che-server:pr-568
quay.io/eclipse/che-dashboard:pr-932

The functionality works as expected.

@akurinnoy akurinnoy requested a review from artaleks9 September 27, 2023 10:49
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 0e96126 into main Sep 27, 2023
12 checks passed
@vinokurig vinokurig deleted the che-22539 branch September 27, 2023 11:19
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/347: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4604: FAILURE

dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

vinokurig added a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants