Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of logs #947

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Reduce number of logs #947

merged 1 commit into from
Oct 24, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR replaces console.logs with pino.js logger and adds ability to change the logLevel dynamically.

What issues does this PR fix or reference?

resolves eclipse-che/che#22533

@akurinnoy akurinnoy self-assigned this Oct 11, 2023
@che-bot
Copy link
Contributor

che-bot commented Oct 11, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-947

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #947 (7c34379) into main (6ed8cc0) will decrease coverage by 0.10%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
- Coverage   82.92%   82.82%   -0.10%     
==========================================
  Files         361      361              
  Lines       37351    37462     +111     
  Branches     2390     2389       -1     
==========================================
+ Hits        30973    31029      +56     
- Misses       6351     6406      +55     
  Partials       27       27              
Flag Coverage Δ
unittests 82.82% <64.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackend/src/devworkspaceClient/services/eventApi.ts 100.00% <100.00%> (+2.97%) ⬆️
...d/src/devworkspaceClient/services/logsApi/index.ts 96.55% <100.00%> (ø)
...-backend/src/devworkspaceClient/services/podApi.ts 97.05% <100.00%> (+0.02%) ⬆️
.../src/devworkspaceClient/services/userProfileApi.ts 87.50% <ø> (+1.78%) ⬆️
...kages/dashboard-backend/src/helpers/getUserName.ts 100.00% <100.00%> (ø)
...ages/dashboard-backend/src/plugins/staticServer.ts 93.47% <100.00%> (+0.29%) ⬆️
packages/dashboard-backend/src/plugins/swagger.ts 92.64% <100.00%> (+0.22%) ⬆️
packages/dashboard-backend/src/app.ts 93.22% <96.66%> (ø)
...src/devworkspaceClient/services/devWorkspaceApi.ts 67.29% <50.00%> (+0.15%) ⬆️
...eClient/services/helpers/prepareCustomObjectAPI.ts 98.21% <94.44%> (+0.10%) ⬆️
... and 10 more

... and 3 files with indirect coverage changes

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-947

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 9e37924 into main Oct 24, 2023
11 of 13 checks passed
@akurinnoy akurinnoy deleted the reduce-logs branch October 24, 2023 14:59
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/373: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/4906: FAILURE

dashboard : 3.x :: Failed in : quay.io/devspaces/dashboard-rhel8:3.11-1
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce amount of logs produced by the dashboard pod
5 participants