Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot Admin Integration #3018

Merged
merged 65 commits into from
Dec 22, 2023

Conversation

iliyan-velichkov
Copy link
Contributor

@iliyan-velichkov iliyan-velichkov commented Nov 21, 2023

Path to access it: http://localhost:8080/spring-admin
Required role: OPERATOR

Admin example
image

Spring Boot Admin
If you want to enable Spring Boot Admin for the Dirigible project, you need to build the project with maven profile spring-boot-admin and then activate spring profile spring-boot-admin.
To do this, you have to execute the following commands:

mvn -T 1C clean install -P spring-boot-admin -D maven.test.skip=true -D skipTests -D maven.javadoc.skip=true -D license.skip=true

java -jar -Dspring.profiles.active=spring-boot-admin build/application/target/dirigible-application-*-executable.jar

Links

@iliyan-velichkov
Copy link
Contributor Author

@delchev @ThuF @vmutafov the PR is for review

build/application/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@ThuF ThuF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm converting this PR as Draft, as we'll merge it once the 9.0.0 version is approved and released.

@iliyan-velichkov Also could you please create an issue about this feature?


public enum DirigibleRole {

DEVELOPER("DEVELOPER"), OPERATOR("OPERATOR");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the values be Developer and Operator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThuF ThuF marked this pull request as draft November 21, 2023 15:20
@ThuF ThuF added this to the 10.0.0 milestone Nov 21, 2023
@iliyan-velichkov
Copy link
Contributor Author

I'm converting this PR as Draft, as we'll merge it once the 9.0.0 version is approved and released.

@iliyan-velichkov Also could you please create an issue about this feature?

#3019

@iliyan-velichkov iliyan-velichkov changed the title Expose Spring Boot Admin Spring Boot Admin Integration Nov 21, 2023
@iliyan-velichkov iliyan-velichkov force-pushed the spring-admin branch 4 times, most recently from 8d47896 to 2f66cb3 Compare November 27, 2023 07:47
DIRIGIBLE_DATABASE_NAMES_CASE_SENSITIVE=true
DIRIGIBLE_SPRING_ADMIN_USERNAME=admin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about security module used is not the basic one (used for demo only)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can test it if you have configured such a system.
In production cases, you are going to use (Spring Cloud Discovery)[https://docs.spring-boot-admin.com/current/getting-started.html#discover-clients-via-spring-cloud-discovery].

tests/pom.xml Outdated Show resolved Hide resolved
@delchev
Copy link
Contributor

delchev commented Nov 27, 2023

In general, can we run spring-admin separately and connect to dirigible instance, instead of to have it embedded? What are the pros and cons?

@iliyan-velichkov
Copy link
Contributor Author

In general, can we run spring-admin separately and connect to dirigible instance, instead of to have it embedded? What are the pros and cons?

As we discussed, I added a separate maven and spring profile. The readme is updated.

@ThuF ThuF linked an issue Nov 29, 2023 that may be closed by this pull request
@iliyan-velichkov iliyan-velichkov marked this pull request as ready for review December 4, 2023 11:39
@iliyan-velichkov
Copy link
Contributor Author

@ThuF @vmutafov @delchev when do we plan to merge this?

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
javax.annotation.Nullable
javax.xml.soap
javax.servlet

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
integration-tests -> tests

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
@delchev
Copy link
Contributor

delchev commented Dec 21, 2023

@iliyan-velichkov can you please resolve conflicts, to be able to merge this PR as well?

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
@iliyan-velichkov
Copy link
Contributor Author

iliyan-velichkov commented Dec 21, 2023

@iliyan-velichkov can you please resolve conflicts, to be able to merge this PR as well?

@delchev done

@delchev delchev merged commit 9ec4efa into eclipse-dirigible:master Dec 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IDE] Spring Boot Admin into Dirigible
3 participants