Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the startserv script as CMD by default #6

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Use the startserv script as CMD by default #6

merged 1 commit into from
Aug 21, 2023

Conversation

OndroMih
Copy link
Contributor

Use the startserv script as CMD by default.
Add README with documentation for each docker tag.

@OndroMih
Use the startserv script as CMD by default.
b185a92 
Add README with documentation for each docker tag.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih OndroMih requested a review from dmatej August 16, 2023 23:05
dmatej
dmatej approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it yet, but if it fails after 7.0.8, we will fix it in another version and I will use still the last commit it for the official build.

@OndroMih
Copy link
Contributor Author

I didn't test it yet, but if it fails after 7.0.8, we will fix it in another version and I will use still the last commit it for the official build.

I don't understand. You tested it with 7.0.8? I tested it with 7.0.8-SNAPSHOT locally (I needed to modify the Dockerfile) and it worked.

@dmatej
Copy link
Contributor

dmatej commented Aug 17, 2023

I didn't test it yet, but if it fails after 7.0.8, we will fix it in another version and I will use still the last commit it for the official build.

I don't understand. You tested it with 7.0.8? I tested it with 7.0.8-SNAPSHOT locally (I needed to modify the Dockerfile) and it worked.

I mean if it would fail after the release of 7.0.8, sorry, bad english. Just a safe backup plan :-)

@OndroMih OndroMih merged commit a0ed280 into main Aug 21, 2023
1 check passed
@OndroMih OndroMih deleted the ondromih-startserv branch August 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OndroMih @dmatej