Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added System property as another fallback option #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lonzak
Copy link

@Lonzak Lonzak commented May 17, 2019

  • Cleaning up resources
  • Added a reinitialize for the TokenManager

Signed-off-by: Eberhard Most eberhard.most@gmail.com

* Cleaning up resources
* Added a reinitialize for the TokenManager

Signed-off-by: Eberhard Most <eberhard.most@gmail.com>
@Lonzak
Copy link
Author

Lonzak commented May 17, 2019

I have
(1)
signed the Contributor Agreement and
(2)
added the signed-off-by footer and
(3)
installed the eclipse-ca-validation from https://github.com/apps/eclipse-eca-validation

What else is missing? This makes it really hard to contribute

Additonally the Detail link points to my old pull-request and not the latest one. Seems to me a bug in github...

@lukasj
Copy link
Member

lukasj commented May 19, 2019

Contributor Agreement and sign-off are required. Who and where says you have to install 'eclipse-eca-validation' app or anyhow work with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants