Fix identity of BindingFacesMessage #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equals/hashCode for FacesMessage in jakartaee/faces#1823 Reproducer: trigger 2 different bean validation errors on the same property
melloware
approved these changes
Dec 26, 2024
arjantijms
approved these changes
Dec 26, 2024
BalusC
added a commit
that referenced
this pull request
Dec 28, 2024
BalusC
added a commit
to jakartaee/faces
that referenced
this pull request
Dec 28, 2024
|
As you are fixing a bug I would have expected to see a test. Did I miss it? |
|
Nope, there is no test. I would also have added a test but the TCK situation was super frustrating at that moment. As the PR is apparently already merged I will add it later via jakartaee/faces#1996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix identity of BindingFacesMessage; it broke since introduction of equals/hashCode for FacesMessage in
jakartaee/faces#1823
Reproducer: trigger 2 different bean validation errors on the same property, it should show 2 separate messages instead of only the last one.
Discovered while analyzing o:validateBean IT failure since switching from Mojarra 4.0.x to 4.1.x.