Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move org.eclipse.equinox.event to use automatic manifest generation #246

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Apr 4, 2023

This enable the new automatic manifest generation for org.eclipse.equinox.event and use annotations for the component.

This is currently work-in-progress to track progress on the Tycho side, currently the following things should be checked:

  • It can actually build the project, this will include tycho-pomless detect this as a regular Tycho project
  • It resolves to the DS version 1.3 as declared in the pde.bnd file
  • It uses Java 1.8 as declared with the -runee instruction here
  • API tools work as expected
  • The resulting bundle manifest looks like we desire

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test Results

     24 files  ±0       24 suites  ±0   11m 59s ⏱️ +14s
2 150 tests ±0  2 104 ✔️ ±0  45 💤 ±0  1 ±0 
2 194 runs  ±0  2 148 ✔️ ±0  45 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit f712713. ± Comparison against base commit b8735a2.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from ca6e83f to e296d09 Compare April 4, 2023 14:55
@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from e296d09 to 773882e Compare April 4, 2023 16:11
@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from 773882e to 838cb0b Compare May 14, 2023 04:41
@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from 838cb0b to 284be42 Compare July 3, 2023 06:50
@laeubi
Copy link
Member Author

laeubi commented Jul 3, 2023

Build currently fails with

Error: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:4.0.0:package-plugin (default-package-plugin) on project org.eclipse.equinox.event: /home/runner/work/equinox/equinox/bundles/org.eclipse.equinox.event/build.properties: bin.includes value(s) must be specified. -> [Help 1]

@laeubi
Copy link
Member Author

laeubi commented Jul 3, 2023

The build now works, but the API Tools can not run successful:

[INFO] --- tycho-apitools:4.0.0:verify (verify) @ org.eclipse.equinox.event ---
[INFO] Resolve API baseline for org.eclipse.equinox:org.eclipse.equinox.event:eclipse-plugin:1.6.300-SNAPSHOT
[INFO] Resolve API tools runtime from MavenRepositoryLocation [location=https://download.eclipse.org/eclipse/updates/4.29-I-builds/]...
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
ERR: org.osgi.service.event;version=0 Not found in [org.eclipse.pde.internal.core.bnd.TargetRepository@255a50a1, bnd-cache [/home/jenkins/.bnd/default-ws/cnf/cache/6.4.1/bnd-cache r/w=false]]

I assume the problem is that Tycho does not resolve the BND requirements when building the API tools target platform, has to investigate on this.

@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from 284be42 to b43a68d Compare July 3, 2023 10:46
@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from b43a68d to 7d64be6 Compare July 30, 2023 17:56
@laeubi
Copy link
Member Author

laeubi commented Jul 31, 2023

I looked a bit deeper at the API tools issue, the problem seems that as the manifest is generated there is now a timing issue, so the results vary from success, to some compile issues reported to errors with access restrictions. So need to investigate if/how we can fix the API Tools application in this regard.

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

Lets se if improved ApiToolsMojo can help here...

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

Lets se if improved ApiToolsMojo can help here...

API tools build now also works 🥇

@laeubi laeubi force-pushed the move_equinox_event_to_bnd branch from d8f4979 to f712713 Compare October 22, 2023 06:16
@laeubi
Copy link
Member Author

laeubi commented Oct 22, 2023

I now added BUNDLE_ROOT_PATH= preference as described here:

to verify the build still works with that setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants