-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move org.eclipse.equinox.event to use automatic manifest generation #246
base: master
Are you sure you want to change the base?
Conversation
Test Results 24 files ±0 24 suites ±0 11m 59s ⏱️ +14s For more details on these failures, see this check. Results for commit f712713. ± Comparison against base commit b8735a2. ♻️ This comment has been updated with latest results. |
ca6e83f
to
e296d09
Compare
bundles/org.eclipse.equinox.event/src/org/eclipse/equinox/internal/event/EventComponent.java
Show resolved
Hide resolved
e296d09
to
773882e
Compare
773882e
to
838cb0b
Compare
838cb0b
to
284be42
Compare
Build currently fails with
|
The build now works, but the API Tools can not run successful:
I assume the problem is that Tycho does not resolve the BND requirements when building the API tools target platform, has to investigate on this. |
284be42
to
b43a68d
Compare
b43a68d
to
7d64be6
Compare
I looked a bit deeper at the API tools issue, the problem seems that as the manifest is generated there is now a timing issue, so the results vary from success, to some compile issues reported to errors with access restrictions. So need to investigate if/how we can fix the API Tools application in this regard. |
7d64be6
to
7015751
Compare
7015751
to
25e9b78
Compare
25e9b78
to
d8f4979
Compare
Lets se if improved ApiToolsMojo can help here... |
API tools build now also works 🥇 |
d8f4979
to
f712713
Compare
I now added to verify the build still works with that setting. |
This enable the new automatic manifest generation for org.eclipse.equinox.event and use annotations for the component.
This is currently work-in-progress to track progress on the Tycho side, currently the following things should be checked:
pde.bnd
file-runee
instruction here