-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use stronger cipher for secure storage #285
use stronger cipher for secure storage #285
Conversation
Test Results 24 files ±0 24 suites ±0 12m 26s ⏱️ -5s For more details on these failures, see this check. Results for commit 7188c80. ± Comparison against base commit e419739. ♻️ This comment has been updated with latest results. |
tests did not fail when ran locally, but 2 failed here, not sure why. are those known issues? |
The failures look caused by the patch as I don't remember seeing these failing . |
thanks @akurtakov - I will investigate. |
The decrypt was throwing different error code with the new cipher. So I adjusted the test to accommodate the new scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need micro-version increases to the bundles. Otherwise looks good to me.
move the default from weaker MD5/DES to a stronger SHA/AES which is available in JVMs. PBEWithMD5AndDES -> PBEWithHmacSHA512AndAES_256
4f1b32c
to
7188c80
Compare
@tjwatson - just pushed a change to up the bundle versions, PTAL. thanks! |
Thanks, I merged it. |
The eclipse-equinox#285 changed IStorageConstants.DEFAULT_CIPHER that is inlined by TabAdvanced in org.eclipse.equinox.security.ui but which was not touched. See eclipse-platform/eclipse.platform.releng.aggregator#1388
FYI, this was one from the root causes of eclipse-platform/eclipse.platform.releng.aggregator#1388. |
The #285 changed IStorageConstants.DEFAULT_CIPHER that is inlined by TabAdvanced in org.eclipse.equinox.security.ui but which was not touched. See eclipse-platform/eclipse.platform.releng.aggregator#1388
thanks @iloveeclipse for catching this! |
move the default from weaker MD5/DES to a stronger SHA/AES which is available in JVMs.
PBEWithMD5AndDES -> PBEWithHmacSHA512AndAES_256