Apply project settings to o.e.osgi.tests #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Torbjorn-Svensson
commented
Oct 1, 2023
Torbjorn-Svensson
commented
- Convert to LF and ensure LF at EOF:
- Removed executable flag on files:
- Format java files:
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
2c84aca to
443dd43
Compare
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
443dd43 to
471c16f
Compare
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
471c16f to
40b2fe5
Compare
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
40b2fe5 to
2a154f0
Compare
|
Rebased PR on 1d9eb47. |
|
Conflicts, please have a look |
This was achieved by running: find . -type f -print0 | \ xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \ xargs -rd'\n' dos2unix -e Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
This was achieved by running: find . -type f -executable -print0 | \ xargs -r0 chmod 644 Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
2a154f0 to
f8d0a1c
Compare
|
Rebased on b297e05. |
This was achieved by running: eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \ -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d` Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi.tests
branch
from
f8d0a1c to
13dabee
Compare
|
Test failure should be fixed now. |
What did you do to fix the tests? |
I simply added a trim of the returned content when comparing to the expected number as the content has already been verified a few lines above and the only thing that is to be tested is that it's the correct number in the file. The change was done here: https://github.com/eclipse-equinox/equinox/compare/f8d0a1c3be3a5db5b2bb9bd8a97eaec49f268119..13dabee294f6c8bb4212391f4a941db6789e04b1 |
|
Thanks @Torbjorn-Svensson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.