Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oomph-Setup] Change Equinox configuration setup to contain only equinox #689

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

HannesWell
Copy link
Member

Add a equinox.core configuration setup that only contains the Equinox and Equinox Binaries repository, opposed to the 'full' equinox configuration that also contains P2.

I used Equinox Core to refer to this repository to resolve the name clash that exists between this repository and the overall organization name. Alternatively we could find another name for the configuration handling the 'full' Equinox organization and rename it. Actually I would be in favor of that but didn't found a good name for it, Equinox Full, Equinox Organization, Equinox SDK, Equinox Complete, Equinox All, all didn't sound like a perfect solution for me.

@laeubi, @merks do you have any suggestions or opinions on that?

This also adds a reference the new equinox.p2 configuration added in the eclipse-equinox/p2 repository.
Additionally change the styled and drag&drop-able Oomph Configuration button in the main README to just display the Equinox Core configuration, not the 'full' Equinox organization config.

The 'full' equinox configuration is also added to the organizations overview page via (currently it's only shown in the CONTRIBUTING file for Equinox

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430

@merks
Copy link
Contributor

merks commented Oct 12, 2024

Perhaps equinox+p2 captures the name of the content without trying to describe or characterize the content...

Copy link

github-actions bot commented Oct 12, 2024

Test Results

  660 files  ±0    660 suites  ±0   1h 16m 44s ⏱️ + 1m 47s
2 201 tests ±0  2 154 ✅ +1   47 💤 ±0  0 ❌  - 1 
6 747 runs  ±0  6 604 ✅ +1  143 💤 ±0  0 ❌  - 1 

Results for commit c2b455e. ± Comparison against base commit 19b406b.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member Author

Perhaps equinox+p2 captures the name of the content without trying to describe or characterize the content...

This could work for the Badge/Button, but I assume one cannot use the + in variable names like for the workspace or installation, can you? At the same time it seems to be a bit specific to me to list the project.
But since the Equinox (repo) and P2 are actually not so strongly related another option could be that we simply drop the organization wide configuration and just have one for Equinox and P2? Respectively remove P2 from the Equinox configuration.

Then we just have a Equinox config (with the equinox and equinox.binaries repository) and a P2 configuration (containing only the p2 repo). On the organization README and CONTRIBUTING file we could then simply list both configs.
Having a config with Equinox+P2 does not seem to be so useful as it can be e.g. for all of JDT or for the Platform SDK (if one really wants to have everything).
WDYT?

Comment on lines -64 to -67
<setupTask
xsi:type="setup:VariableTask"
name="eclipse.git.authentication.style"
defaultValue="anonymous"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merks is it necessary to define this variable? As far as I can tell, the default is already anonymous anyways:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not. I think I changed this from the olden days when one typically wanted a gerrit URI for contribution, but now one can use anonymous and commit to a fork, and even the committers do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, personally I usually fetch from the upstream/original repo using https and push to my fork via SSH.

Ok, good. Then we can probably remove it from all other configurations. I can take care of that.
Thanks.

Copy link
Member Author

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since the Equinox (repo) and P2 are actually not so strongly related another option could be that we simply drop the organization wide configuration and just have one for Equinox and P2? Respectively remove P2 from the Equinox configuration.

I have now implemented this in this PR.
With that this is ready from my side.

I'll also update the GH organization pages accordingly later, but I have to leave for now.

@HannesWell HannesWell force-pushed the oomph-configuration branch 2 times, most recently from 91f49aa to c2b455e Compare October 13, 2024 15:53
Remove the p2 project from the EquinoxConfiguration.setup and
unify/clean-up it's content.

And add a reference to the new equinox.p2 configuration added to the
eclipse-equinox/p2 repository.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
@HannesWell HannesWell changed the title [Oomph-Setup] Add equinox.core configuration setup [Oomph-Setup] Change Equinox configuration setup to contain only equinox Oct 13, 2024
@HannesWell
Copy link
Member Author

HannesWell commented Oct 13, 2024

Since there were no objecting remarks in the meantime I assume this is ready for submission.

@HannesWell HannesWell merged commit 9ee49aa into eclipse-equinox:master Oct 13, 2024
8 of 10 checks passed
@HannesWell HannesWell deleted the oomph-configuration branch October 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants