Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying additional JVM arguments #690

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ShadelessFox
Copy link
Contributor

@ShadelessFox ShadelessFox commented Oct 16, 2024

This pull request adds a new launcher argument, --launcher.additionalVmargs, that is supposed to be followed by a list of locations of files containing extra JVM arguments. Locations can potentially contain environment-variable strings in the form of %VariableName% regardless of the platform:

--launcher.additionalVmargs
%XDG_DATA_HOME%/DBeaverData/settings/dbeaver.vmargs
%HOME%/.local/share/DBeaverData/settings/dbeaver.vmargs

The launcher will attempt to read a file for every location in the declaration order until it succeeds. JVM arguments specified in such a file have higher priority than the ones defined in the launcher arguments or the configuration file.

A file containing extra JVM arguments follows the same structure as any other configuration file: every new argument is placed on its own line:

-Xms64M
-Xmx128M

The argument is intended to be used by developers of Eclipse RCP applications. It can be defined as <programArgs> in the .product file to allow end-users to specify JVM arguments if they can't do that otherwise by modifying the configuration file.

Additionally, 7e684f2 brings configuration file resolution for the console launcher with the -cli postfix in addition to the existing c postfix on Windows.

@ShadelessFox ShadelessFox marked this pull request as draft October 16, 2024 16:23
@ShadelessFox ShadelessFox marked this pull request as ready for review October 18, 2024 09:47
Copy link

github-actions bot commented Nov 7, 2024

Test Results

  660 files  ±0    660 suites  ±0   1h 16m 57s ⏱️ - 1m 7s
2 201 tests ±0  2 154 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 747 runs  ±0  6 604 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 6962fda. ± Comparison against base commit 2815608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants