Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownloadManager - remove unnecessary done() call on ProgressMonitor #578

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

Test Results

  375 files  ±0    375 suites  ±0   44m 3s ⏱️ - 1m 16s
1 904 tests ±0  1 901 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 712 runs  ±0  6 703 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 71c67fa. ± Comparison against base commit 1a42e02.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor Author

vogella commented Dec 3, 2024

@ptziegler a full text search shows tons of .done() in the repo.

Can you have a quick look at this trivial change?

Copy link
Contributor

@ptziegler ptziegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method already has a SubMonitor, which explicitly says that done() doesn't need to be called. So that looks fine to me.

@vogella vogella merged commit aa3eef4 into eclipse-equinox:master Dec 4, 2024
12 checks passed
@vogella vogella deleted the downloadmanager branch December 4, 2024 07:57
@vogella
Copy link
Contributor Author

vogella commented Dec 4, 2024

Thanks @ptziegler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants