Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROS 2 RHEL build #2119

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Nov 28, 2023

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

  • Silently skip introspection build if the curses library is not found

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Nov 28, 2023
@mossmaurice mossmaurice self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #2119 (7a1be0d) into master (f0622f1) will decrease coverage by 0.08%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

❗ Current head 7a1be0d differs from pull request most recent head e0936f1. Consider uploading reports for the commit e0936f1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2119      +/-   ##
==========================================
- Coverage   80.39%   80.31%   -0.08%     
==========================================
  Files         416      417       +1     
  Lines       16143    16142       -1     
  Branches     2252     2252              
==========================================
- Hits        12978    12965      -13     
- Misses       2369     2382      +13     
+ Partials      796      795       -1     
Flag Coverage Δ
unittests 80.10% <ø> (-0.08%) ⬇️
unittests_timing 15.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

…ibrary is not found (e.g. ROS 2 RHEL)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the iox-#2099-fix-ros-2-rhel-build-master branch from b506099 to 7a1be0d Compare November 30, 2023 10:04
@mossmaurice mossmaurice removed the request for review from dkroenke November 30, 2023 10:04
elBoberido
elBoberido previously approved these changes Nov 30, 2023
@elBoberido
Copy link
Member

Not sure what's going on with the integration builds

@dkroenke
Copy link
Member

Not sure what's going on with the integration builds

@elBoberido @mossmaurice This is most likely related to an issue in colcon: colcon/colcon-core#602
There are some tips mentioned on how to mitigate this that can be adapted in our CI scripts.

@elBoberido
Copy link
Member

@mossmaurice can you update the ros-tooling/setup-ros action to v0.7 before the merge?

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@elBoberido
Copy link
Member

@mossmaurice thanks very much :)

@mossmaurice mossmaurice merged commit 88a96c8 into eclipse-iceoryx:master Dec 4, 2023
27 checks passed
@mossmaurice mossmaurice deleted the iox-#2099-fix-ros-2-rhel-build-master branch December 4, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants