ArrayStoreException in SelectionParser.buildMoreCompletionContext (#2463

) * Fixes #2443
eclipse-jdt · May 21, 2024 · 75ade7e · 75ade7e
1 parent eddfb7d
commit 75ade7e
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/...eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests12To15.java b/...eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests12To15.java
@@ -1702,4 +1702,35 @@ public static void main(String[] args) {
 		elements
 	);
 }
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2443
+// ArrayStoreException in SelectionParser.buildMoreCompletionContext
+public void testGH2443() throws JavaModelException {
+	this.wc = getWorkingCopy("/Resolve15/src/X.java",
+					"""
+					 public class X {
+
+						public static void main(String[] args) {
+
+							for (String sourcePath : args) {
+								new X() {
+									public void foo(String file) {
+										file.hashCode();
+									}
+
+								};
+							}
+						}
+					}
+					""");
+	String str = this.wc.getSource();
+	String selection = "file";
+	int start = str.lastIndexOf(selection);
+	int length = selection.length();
+	IJavaElement[] elements = this.wc.codeSelect(start, length);
+	assertElementsEqual(
+		"Unexpected elements",
+		"file [in foo(String) [in <anonymous #1> [in main(String[]) [in X [in [Working copy] X.java [in <default> [in src [in Resolve15]]]]]]]]",
+		elements
+	);
+}
 }
diff --git a/...lipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java b/...lipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java
@@ -1929,6 +1929,7 @@ protected boolean restartRecovery() {
 			case K_INSIDE_EXPRESSION_SWITCH:
 			case K_INSIDE_IF:
 			case K_INSIDE_WHILE:
+			case K_INSIDE_FOR_EACH:
 				deferRestartOnLocalType = true;
 				break;
 			case K_TYPE_DELIMITER: