@SuppressWarnings("removal") does not work

[laeubi]

If I look at

org.eclipse.pde.internal.core.product.ArgumentsInfo

it has

	@SuppressWarnings("deprecation")
	@Override
	public String getCompleteProgramArguments(String os, String arch) {

but eclipse claims

Unnecessary @SuppressWarnings("deprecation")

so far so good, then we can remove it, but now I don't get any warning at all even though a forRemoval should be even more serve

this was recently changed here:

• eclipse-platform/eclipse.platform@9ee38b5

[jukzi]

After deprecation for removal that method would now need a @SuppressWarnings("removal") instead. However it does not work in this case -> bug
see also #469 @subyssurendran666

[laeubi]

After deprecation for removal that method would now need a @SuppressWarnings("removal") instead.

That's what I would expect that it still complains (but need a different suppress.

[HannesWell]

Could anyone from JDT please have a look at this? The case described above is causing build-failures in PDE due to new warnings and actually I don't want to remove the suppression now just to add it back later when this is fixed.

If you can point me to the place where this can be fixed, I can also have a look by myself.

[srikanth-sankaran]

Could anyone from JDT please have a look at this? The case described above is causing build-failures in PDE due to new warnings and actually I don't want to remove the suppression now just to add it back later when this is fixed.

If you can point me to the place where this can be fixed, I can also have a look by myself.

See call sites of org.eclipse.jdt.internal.compiler.problem.ProblemReporter.unusedWarningToken(Expression) for the logic that emits the Unnecessary @SuppressWarnings(\<Token\>)

org.eclipse.jdt.internal.compiler.ast.Annotation.recordSuppressWarnings(Scope, int, int, boolean) and org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.finalizeProblems() are places of interest, in the latter the block of code that carries the comment // flag SuppressWarnings which had no effect (only if no (mandatory) error got detected within unit

In general a good way to find out where different things happen in ECJ is to plant a breakpoint in org.eclipse.jdt.internal.compiler.problem.ProblemHandler.handle(int, String[], int, String[], int, int, int, ReferenceContext, CompilationResult)

EVERY Error/Warning/Info diagnostics go through this method.

So plant a breakpoint there and give the compiler some workload that would trigger a "relevant" message.

Call stack points to the smoking gun 😄

(Sorry that I am personally not able to jump on this task - I am trying to wrap up Enhanced switches redesign/reimplementation before the year end holidays)

Good luck. I am available to review PRs though