Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launching] Don't add -Djava.security.manager=allow for Java-24 or later #1516

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Dec 13, 2024

Since Java-24 the security-manager cannot be used anymore and launching a Java-24 VM fails to launch if the VM-argument
-Djava.security.manager=allow is specified.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2623

Adn improve addition of default VM arguments for Eclipse apps:
Simplify the code and add arguments only if they are not even added with another value.

CC @merks

HannesWell and others added 3 commits December 14, 2024 00:01
Simplify the code and add arguments only if they are not even added with
another value.
Since Java-24 the security-manager cannot be used anymore and launching
a Java-24 VM fails to launch if the VM-argument
'-Djava.security.manager=allow' is specified.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2623
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

features/org.eclipse.pde.unittest.junit-feature/feature.xml
ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
ui/org.eclipse.pde.unittest.junit/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From bbfc7866ad926a94cb1897a014f3d9793535601b Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 13 Dec 2024 23:35:07 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/features/org.eclipse.pde.unittest.junit-feature/feature.xml b/features/org.eclipse.pde.unittest.junit-feature/feature.xml
index 2da46788b0..6f177151f0 100644
--- a/features/org.eclipse.pde.unittest.junit-feature/feature.xml
+++ b/features/org.eclipse.pde.unittest.junit-feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.pde.unittest.junit"
       label="%featureName"
-      version="1.0.900.qualifier"
+      version="1.0.1000.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
index a4a330bb39..3ef88e7cdb 100644
--- a/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.launching/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.launching;singleton:=true
-Bundle-Version: 3.13.200.qualifier
+Bundle-Version: 3.13.300.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-Vendor: %provider-name
 Require-Bundle: org.eclipse.jdt.junit.core;bundle-version="[3.6.0,4.0.0)",
diff --git a/ui/org.eclipse.pde.unittest.junit/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.unittest.junit/META-INF/MANIFEST.MF
index 1606ab427e..71c72293b4 100644
--- a/ui/org.eclipse.pde.unittest.junit/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.unittest.junit/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.pde.unittest.junit
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.unittest.junit;singleton:=true
-Bundle-Version: 1.1.500.qualifier
+Bundle-Version: 1.1.600.qualifier
 Bundle-Activator: org.eclipse.pde.unittest.junit.JUnitPluginTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   285 files  ±0     285 suites  ±0   51m 21s ⏱️ +12s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 34f1194. ± Comparison against base commit 51ef6fe.

@HannesWell
Copy link
Member Author

The complaint about new warnings is a JDT error:

Everything else looks good, submitting.

@HannesWell HannesWell merged commit ba8fc7f into eclipse-pde:master Dec 14, 2024
15 of 18 checks passed
@HannesWell HannesWell deleted the no-security-manager-in-24 branch December 14, 2024 08:43
@HannesWell
Copy link
Member Author

Actually I wanted to have the first commit submitted as part of #1515, but I confused the tabs... Anyways since this result is equal, that's not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants