ExceptionHandlingFlowContext: use java.util.IdentityHashMap #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoids raw types * deletes custom ObjectCache ObjectCache implemented a HashMap using hashCode() but not equals(). Instead it used == identity. JDK offers a special Map for identity since 1.4, consistently using System.identityHashCode(). relates to eclipse-jdt#3412 Also solved follow up * LambdaExpression "Redundant specification of type arguments"
jukzi
force-pushed
the
ExceptionHandlingFlowContext
branch
from
110945d to
bad35f0
Compare
|
Thanks @juzki I will review these tomorrow |
srikanth-sankaran
approved these changes
Dec 11, 2024
|
@srikanth-sankaran thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectCache implemented a HashMap using hashCode() but not equals(). Instead it used == identity. JDK offers a special Map for identity since 1.4, consistently using System.identityHashCode().
relates to #3412