Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClasspathDirectory.directoryList(): check parent package first #3445 #3450

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Dec 13, 2024

Avoid nested directoryCache.computeIfAbsent to fix possible IllegalStateException with long upper case packages.

fixes
#3445

…e-jdt#3445

Avoid nested directoryCache.computeIfAbsent to fix possible
IllegalStateException with long upper case packages.

fixes
eclipse-jdt#3445
@jukzi jukzi requested a review from mpalat December 13, 2024 10:25
@jukzi
Copy link
Contributor Author

jukzi commented Dec 13, 2024

cc @szarnekow

Copy link
Contributor

@mpalat mpalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jukzi Thanks for reverting - Looks fine.

+1

@jukzi jukzi merged commit ab8d090 into eclipse-jdt:master Dec 13, 2024
10 checks passed
@jukzi jukzi deleted the computeIfAbsent branch December 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible IllegalStateException due to recursive call on ConcurrentHashMap in directory list.
3 participants