Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: use method name to find unqualified Stacktraces #115

Closed
jukzi opened this issue Aug 31, 2022 · 3 comments · Fixed by #547
Closed

improvement: use method name to find unqualified Stacktraces #115

jukzi opened this issue Aug 31, 2022 · 3 comments · Fixed by #547
Assignees
@SougandhS
Labels
enhancement New feature or request

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 31, 2022

paste this into Java Stack Trace Console in a Platform SDK workspace:

Project.writeDescription(int) line: 1402

click the link (feature from #5)
image

=> Select type dialog opens. because "Project" is unqualified and could mean various types:
image

However the logic could see that only one of those classes has a "writeDescription" method. That logic already exists in the command Navigate/"Open from Clipboard" and does automatically finds and opens the right class.

...
Some types would also not qualify for the link as they are not even 1402 lines long

cc @trancexpress - interested to work on this?
@jukzi jukzi changed the title improvement use method name to find unqualified Stacktraces improvement: use method name to find unqualified Stacktraces Aug 31, 2022
@jukzi jukzi added the enhancement New feature or request label Feb 8, 2024
@SougandhS
Copy link
Contributor

Hi @mpalat, could you please assign this to me

@SougandhS SougandhS mentioned this issue Sep 17, 2024
Merged
3 tasks
@SougandhS
Copy link
Contributor

Hi @jukzi
enhancement has been implemented -> PR@498
Shall we close this PR now ?

@jukzi jukzi closed this as completed Sep 24, 2024
@iloveeclipse
Copy link
Member

See #543 and issues on #544

Looking on the number of issues I've found above, I will now revert #498 PR as

  1. the code has multiple regressions
  2. The code in org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink.searchCompleted(Object, String, int, IStatus) is simply not maintainable.

Revert PR: #545

I would recommend to rewrite #498.

Reopening this ticket.

@iloveeclipse iloveeclipse reopened this Oct 21, 2024
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 22, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
6e3fe87 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
@SougandhS SougandhS mentioned this issue Oct 22, 2024
Merged
3 tasks
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 22, 2024
@SougandhS
Filtering unqualified Stacktraces Code review eclipse-jdt#115
8f84fea 
Code review changes + Java Doc + further code optimization

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 28, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
0053e49 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 28, 2024
@SougandhS
Filtering unqualified Stacktraces Code review eclipse-jdt#115
8e6f576 
Code review changes + Java Doc + further code optimization

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 29, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
60d19e6 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 29, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
3a15766 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 31, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
32d9ef8 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Oct 31, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
f595ab8 
Using method signature to filter unqualified stacktraces generated in
java stacktrace console. + Includes code review changes

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 1, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
b8fc106 
Using method signature to filter unqualified stacktraces generated in
java stacktrace console. + Includes code review changes

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 1, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
0f2ebc7 
Using method signature to filter unqualified stacktraces generated in
java stacktrace console. + Includes code review changes

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
be2ed34 
Using method signature to filter unqualified stacktraces generated from
java stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
e1efb4f 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 19, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
7e367e3 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 27, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
139e5d6 
using method name to filter unqualified stacktraces generated in java
stacktrace console.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Nov 28, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
e0b97ea 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate results

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 3, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
21fb41b 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate results

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 3, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
fd75f82 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 4, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
600dc85 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 4, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
4a53e8b 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 4, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
17c4525 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
ecf4c77 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
f84f53f 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
a4afc35 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
SougandhS added a commit to SougandhS/eclipse.jdt.debug that referenced this issue Dec 6, 2024
@SougandhS
Filtering unqualified Stacktraces eclipse-jdt#115
249de72 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
gzsombor pushed a commit to gzsombor/eclipse.jdt.debug that referenced this issue Dec 10, 2024
@SougandhS @jukzi
Filtering unqualified Stacktraces eclipse-jdt#115
ddf0a0a 
Using method name to filter unqualified stacktraces generated in java
stacktrace console to provide more accurate search results.

Fixes eclipse-jdt#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SougandhS SougandhS

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filtering unqualified Stacktraces #115 SougandhS/eclipse.jdt.debug
3 participants
@iloveeclipse @jukzi @SougandhS