Filtering unqualified Stacktraces #115 #547

SougandhS · 2024-10-22T09:07:41Z

using method name to filter unqualified stacktraces generated in java stacktrace console.

Fixes #115
Includes handling for #544

What it does

How to test

Author checklist

I have thoroughly tested my changes
The change is following the coding conventions
I have signed the Eclipse Contributor Agreement (ECA)

SougandhS · 2024-10-22T09:37:26Z

Hi @iloveeclipse & @jukzi
I wrote the code changes again like you suggested. Also handled additional cases in #544. Could you pls check on this ?

iloveeclipse

Please try to write code that "fits on the screen".
Methods that have nesting level like here and if blocks that need to be scrolled down to see where it ends are "no go". The code is impossible to review / maintain.

See my proposals in code how the code should be improved.

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java

SougandhS · 2024-10-22T17:06:04Z

Please try to write code that "fits on the screen". Methods that have nesting level like here and if blocks that need to be scrolled down to see where it ends are "no go". The code is impossible to review / maintain.

See my proposals in code how the code should be improved.

Thanks for the proposals @iloveeclipse, now I have decoupled it into many like you suggested and it is more readable than previous.

iloveeclipse · 2024-10-22T17:07:23Z

I'm away from PC till next week, code looks much better now, thanks.

SougandhS · 2024-10-22T17:08:05Z

I'm away from PC till next week, code looks much better now, thanks.

Thank you @iloveeclipse

jukzi · 2024-10-28T08:20:54Z

I have tested this pr with a hundret random stacktraces and did not run into any error. @iloveeclipse please finish review.

SougandhS · 2024-10-28T13:39:51Z

Hi @iloveeclipse, could u pls check this again ?

SougandhS · 2024-10-29T06:42:25Z

Hi @iloveeclipse

Hi @iloveeclipse, could u pls check this again ?

iloveeclipse · 2024-10-29T06:48:37Z

Hi @iloveeclipse

Hi @iloveeclipse, could u pls check this again ?

I will. Please squash two commits into one & force push this PR.

SougandhS · 2024-10-29T06:55:16Z

Hi @iloveeclipse

Hi @iloveeclipse, could u pls check this again ?

I will. Please squash two commits into one & force push this PR.

Thanks @iloveeclipse, will do it now

SougandhS · 2024-10-29T06:59:19Z

Hi @iloveeclipse , I have squashed the commits to one now.

iloveeclipse

Please check the coverage of the new code, it suggests that the code either not needed or there are no tests added:

For this line at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109) I get an error in the log and a selection dialog for two types, one of them is bin.org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher:

Java Model Exception: Error in Java Model (code 969): bin.org.eclipse.core.runtime.internal.adaptor [in /data/git/equinox/bundles/org.eclipse.osgi/bin] does not exist
	at org.eclipse.jdt.internal.core.JavaElement.newJavaModelException(JavaElement.java:556)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:234)
	at org.eclipse.jdt.internal.core.Openable.openAncestors(Openable.java:508)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:228)
	at org.eclipse.jdt.internal.core.JavaElement.openWhenClosed(JavaElement.java:569)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:292)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:278)
	at org.eclipse.jdt.internal.core.BinaryType.getClassFileInfo(BinaryType.java:232)
	at org.eclipse.jdt.internal.core.BinaryType.getChildren(BinaryType.java:195)
	at org.eclipse.jdt.internal.core.JavaElement.getChildrenOfType(JavaElement.java:247)
	at org.eclipse.jdt.internal.core.BinaryType.getMethods(BinaryType.java:494)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink.extractFromResults(JavaStackTraceHyperlink.java:316)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink.filterClasses(JavaStackTraceHyperlink.java:245)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink$3.runInUIThread(JavaStackTraceHyperlink.java:208)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:148)

On master, I don't get an error (but still see unexpected bin.org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher type proposed in a list with the "right" one.

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java

SougandhS · 2024-10-31T13:40:21Z

Please check the coverage of the new code, it suggests that the code either not needed or there are no tests added:

For this line at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109) I get an error in the log and a selection dialog for two types, one of them is bin.org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher:

Java Model Exception: Error in Java Model (code 969): bin.org.eclipse.core.runtime.internal.adaptor [in /data/git/equinox/bundles/org.eclipse.osgi/bin] does not exist
	at org.eclipse.jdt.internal.core.JavaElement.newJavaModelException(JavaElement.java:556)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:234)
	at org.eclipse.jdt.internal.core.Openable.openAncestors(Openable.java:508)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:228)
	at org.eclipse.jdt.internal.core.JavaElement.openWhenClosed(JavaElement.java:569)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:292)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:278)
	at org.eclipse.jdt.internal.core.BinaryType.getClassFileInfo(BinaryType.java:232)
	at org.eclipse.jdt.internal.core.BinaryType.getChildren(BinaryType.java:195)
	at org.eclipse.jdt.internal.core.JavaElement.getChildrenOfType(JavaElement.java:247)
	at org.eclipse.jdt.internal.core.BinaryType.getMethods(BinaryType.java:494)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink.extractFromResults(JavaStackTraceHyperlink.java:316)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink.filterClasses(JavaStackTraceHyperlink.java:245)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink$3.runInUIThread(JavaStackTraceHyperlink.java:208)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:148)

On master, I don't get an error (but still see unexpected bin.org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher type proposed in a list with the "right" one.

Done - Added more tests to cover those areas.
Provided additional check and removed "bin" starting results.

SougandhS · 2024-11-04T10:01:30Z

Hi @iloveeclipse
I have made the code changes as per review

iloveeclipse

I have no time left today for the review due other duties, and will be back at the keyboard next Monday again, sorry.

I saw the coverage is increased, this is good. However, I also see the hack for handling broken "bin" types and that should be removed / fixed properly in a different PR.

Please note, you have again two commits on the branch - it should be one.

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java

SougandhS · 2024-11-06T03:19:35Z

I have no time left today for the review due other duties, and will be back at the keyboard next Monday again, sorry.

I saw the coverage is increased, this is good. However, I also see the hack for handling broken "bin" types and that should be removed / fixed properly in a different PR.

Please note, you have again two commits on the branch - it should be one.

No problem.. will clean up everything 👍

SougandhS · 2024-11-11T07:04:46Z

I have no time left today for the review due other duties, and will be back at the keyboard next Monday again, sorry.
I saw the coverage is increased, this is good. However, I also see the hack for handling broken "bin" types and that should be removed / fixed properly in a different PR.
Please note, you have again two commits on the branch - it should be one.

No problem.. will clean up everything 👍

I have done the changes and squashed the commits to one now.

SougandhS · 2024-11-19T04:17:37Z

I saw the coverage is increased, this is good. However, I also see the hack for handling broken "bin" types and that should be removed / fixed properly in a different PR.

Hi @iloveeclipse, for the additional bin file pickup in results I wasn't able to reproduce the same in my local, I'm always getting results without bin. Can you check that again ?

eclipse-jdt-bot · 2024-11-27T02:07:35Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
org.eclipse.jdt.debug.ui/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From fce97a299bbf7d079e7b433ef308faa255b4c5c3 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Thu, 28 Nov 2024 04:18:41 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF b/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
index e651afa8a..06269ace2 100644
--- a/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.debug.ui; singleton:=true
-Bundle-Version: 3.13.600.qualifier
+Bundle-Version: 3.13.700.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.debug.ui.JDIDebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.debug.ui/pom.xml b/org.eclipse.jdt.debug.ui/pom.xml
index dceebf96d..597b96d81 100644
--- a/org.eclipse.jdt.debug.ui/pom.xml
+++ b/org.eclipse.jdt.debug.ui/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.debug.ui</artifactId>
-  <version>3.13.600-SNAPSHOT</version>
+  <version>3.13.700-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   <properties>
   	<defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

iloveeclipse

The latest patch has 78% test coverage and all but one new methods seem to be tested, this is good. Also I've tested few stack traces without errors - for the first time :-) Also good.
So if @jukzi is OK with this patch, let's merge.

Patch looks better now

jukzi · 2024-12-03T16:35:02Z

since there have been some changes since my last test, i would like to test this tomorrow once more.

SougandhS · 2024-12-04T06:15:32Z

The latest patch has 78% test coverage and all but one new methods seem to be tested, this is good. Also I've tested few stack traces without errors - for the first time :-) Also good. So if @jukzi is OK with this patch, let's merge.

got 81% coverage now

jukzi · 2024-12-04T08:02:57Z

Build repeatedly fails with Could not find artifact org.eclipse.jdt:ecj:jar:3.40.100-SNAPSHOT in eclipse-snapshots , need help @akurtakov @merks

00:01:35.806  Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin org.eclipse.tycho:tycho-compiler-plugin:4.0.10 or one of its dependencies could not be resolved:
00:01:35.806  	Could not find artifact org.eclipse.jdt:ecj:jar:3.40.100-SNAPSHOT in eclipse-snapshots (https://repo.eclipse.org/content/repositories/eclipse-snapshots/)

akurtakov · 2024-12-04T08:13:59Z

It's infrastructure issue - I've opened https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5387 for another case but feel free to open a new one or comment to this one.

jukzi

I tested some stacktraces. Most work. But it fails on some (i used the stacktraces that failed the build of this PR :-) ):

00:01:35.805      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
00:01:35.805      at java.lang.reflect.Method.invoke (Method.java:580)
00:01:35.805      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
00:01:35.805      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
00:01:35.805      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
00:01:35.805      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

!ENTRY org.eclipse.ui.workbench 4 0 2024-12-04 09:09:04.873
!MESSAGE An internal error has occurred.
!STACK 0
java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 9
	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
	at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
	at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4865)
	at java.base/java.lang.String.substring(String.java:2834)
	at org.eclipse.jdt.internal.debug.ui.console.JavaStackTraceHyperlink$3.runInUIThread(JavaStackTraceHyperlink.java:213)

instead of using low level methods like substring, indexof you would be better of using pattern matching as in org.eclipse.jdt.internal.debug.ui.actions.OpenFromClipboardAction

You may also want to improve error handling to add the text to the exception that could not be parsed.

SougandhS · 2024-12-04T08:19:36Z

level

will check this 👍

SougandhS · 2024-12-04T17:23:27Z

Hi @jukzi , I have replaced all the indexof & substring in critical sections and handled new stack traces (those new traces wont give proper generatedLink)

You may also want to improve error handling to add the text to the exception that could not be parsed.

for this I should make changes in platform ui ?

jukzi

I have tested the change again. I could not find any error anymore. potential multithreading issues have to be fixed, then its good to go from my side.

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java

Using method name to filter unqualified stacktraces generated in java stacktrace console to provide more accurate search results. Fixes eclipse-jdt#115

jukzi

LGTM, lets wait for the build

lgtm

SougandhS · 2024-12-10T04:20:04Z

LGTM, lets wait for the build

Build completed without issues.

jukzi · 2024-12-10T06:46:08Z

Thanks for the reminder and contributions.

SougandhS · 2024-12-10T06:47:35Z

Thank you @iloveeclipse & @jukzi for the detailed review.

iloveeclipse requested changes Oct 22, 2024

View reviewed changes

SougandhS requested a review from iloveeclipse October 22, 2024 17:03

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from 8f84fea to 8e6f576 Compare October 28, 2024 08:30

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from 8e6f576 to 60d19e6 Compare October 29, 2024 06:58

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from 60d19e6 to 3a15766 Compare October 29, 2024 09:00

iloveeclipse previously requested changes Oct 29, 2024

View reviewed changes

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from 3a15766 to f595ab8 Compare October 31, 2024 16:29

SougandhS requested a review from iloveeclipse October 31, 2024 17:00

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from b8fc106 to 0f2ebc7 Compare November 1, 2024 12:48

iloveeclipse reviewed Nov 5, 2024

View reviewed changes

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java Outdated Show resolved Hide resolved

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from be2ed34 to e1efb4f Compare November 6, 2024 04:16

SougandhS requested a review from iloveeclipse November 6, 2024 06:45

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from e1efb4f to 7e367e3 Compare November 19, 2024 03:44

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from 7e367e3 to 139e5d6 Compare November 27, 2024 02:01

iloveeclipse reviewed Dec 3, 2024

View reviewed changes

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from fd75f82 to 600dc85 Compare December 4, 2024 05:41

jukzi requested changes Dec 4, 2024

View reviewed changes

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch 2 times, most recently from 4a53e8b to 17c4525 Compare December 4, 2024 17:11

SougandhS requested a review from jukzi December 4, 2024 17:14

jukzi previously requested changes Dec 5, 2024

View reviewed changes

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch 2 times, most recently from ecf4c77 to f84f53f Compare December 6, 2024 04:55

SougandhS requested a review from jukzi December 6, 2024 04:56

jukzi reviewed Dec 6, 2024

View reviewed changes

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java Outdated Show resolved Hide resolved

jukzi reviewed Dec 6, 2024

View reviewed changes

...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java Outdated Show resolved Hide resolved

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from f84f53f to a4afc35 Compare December 6, 2024 07:15

Filtering unqualified Stacktraces eclipse-jdt#115

249de72

Using method name to filter unqualified stacktraces generated in java stacktrace console to provide more accurate search results. Fixes eclipse-jdt#115

SougandhS force-pushed the Java_Stack_Trace_Enhancement branch from a4afc35 to 249de72 Compare December 6, 2024 07:16

SougandhS requested a review from jukzi December 6, 2024 07:16

jukzi reviewed Dec 6, 2024

View reviewed changes

jukzi merged commit ddf0a0a into eclipse-jdt:master Dec 10, 2024
11 checks passed

jukzi added the enhancement New feature or request label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filtering unqualified Stacktraces #115 #547

Filtering unqualified Stacktraces #115 #547

SougandhS commented Oct 22, 2024 •

edited

Loading

SougandhS commented Oct 22, 2024

iloveeclipse left a comment

SougandhS commented Oct 22, 2024

iloveeclipse commented Oct 22, 2024

SougandhS commented Oct 22, 2024

jukzi commented Oct 28, 2024

SougandhS commented Oct 28, 2024

SougandhS commented Oct 29, 2024

iloveeclipse commented Oct 29, 2024

SougandhS commented Oct 29, 2024

SougandhS commented Oct 29, 2024

iloveeclipse left a comment

SougandhS commented Oct 31, 2024

SougandhS commented Nov 4, 2024

iloveeclipse left a comment

SougandhS commented Nov 6, 2024

SougandhS commented Nov 11, 2024

SougandhS commented Nov 19, 2024

eclipse-jdt-bot commented Nov 27, 2024 •

edited

Loading

iloveeclipse left a comment

jukzi commented Dec 3, 2024

SougandhS commented Dec 4, 2024 •

edited

Loading

jukzi commented Dec 4, 2024

akurtakov commented Dec 4, 2024

jukzi left a comment

SougandhS commented Dec 4, 2024

SougandhS commented Dec 4, 2024 •

edited

Loading

jukzi left a comment

jukzi left a comment

SougandhS commented Dec 10, 2024

jukzi commented Dec 10, 2024

SougandhS commented Dec 10, 2024

Filtering unqualified Stacktraces #115 #547

Filtering unqualified Stacktraces #115 #547

Conversation

SougandhS commented Oct 22, 2024 • edited Loading

What it does

How to test

Author checklist

SougandhS commented Oct 22, 2024

iloveeclipse left a comment

Choose a reason for hiding this comment

SougandhS commented Oct 22, 2024

iloveeclipse commented Oct 22, 2024

SougandhS commented Oct 22, 2024

jukzi commented Oct 28, 2024

SougandhS commented Oct 28, 2024

SougandhS commented Oct 29, 2024

iloveeclipse commented Oct 29, 2024

SougandhS commented Oct 29, 2024

SougandhS commented Oct 29, 2024

iloveeclipse left a comment

Choose a reason for hiding this comment

SougandhS commented Oct 31, 2024

SougandhS commented Nov 4, 2024

iloveeclipse left a comment

Choose a reason for hiding this comment

SougandhS commented Nov 6, 2024

SougandhS commented Nov 11, 2024

SougandhS commented Nov 19, 2024

eclipse-jdt-bot commented Nov 27, 2024 • edited Loading

iloveeclipse left a comment

Choose a reason for hiding this comment

jukzi commented Dec 3, 2024

SougandhS commented Dec 4, 2024 • edited Loading

jukzi commented Dec 4, 2024

akurtakov commented Dec 4, 2024

jukzi left a comment

Choose a reason for hiding this comment

SougandhS commented Dec 4, 2024

SougandhS commented Dec 4, 2024 • edited Loading

jukzi left a comment

Choose a reason for hiding this comment

jukzi left a comment

Choose a reason for hiding this comment

SougandhS commented Dec 10, 2024

jukzi commented Dec 10, 2024

SougandhS commented Dec 10, 2024

SougandhS commented Oct 22, 2024 •

edited

Loading

eclipse-jdt-bot commented Nov 27, 2024 •

edited

Loading

SougandhS commented Dec 4, 2024 •

edited

Loading

SougandhS commented Dec 4, 2024 •

edited

Loading