Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lambda type check by name for java21. Fix #300 #302

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Sep 2, 2023

What it does

The lambda type check is improved to support naming patterns for both java 21 and prior versions. The naming patterns are as follows

Java 21: Bug575551$$Lambda.0x000000e8010079d8
Pre Java 21: Bug575551$$Lambda$20.0x0000000801005be0

How to test

Run the LambdaVariableTest with both Java 21 and Java 17.

Author checklist

@gayanper gayanper requested a review from SarikaSinha September 2, 2023 16:41
Copy link
Member

@SarikaSinha SarikaSinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, If you get some time, it will be good to add some negative testcase for the "name" to test the Pattern completely.

@SarikaSinha SarikaSinha merged commit a6c1b81 into eclipse-jdt:master Sep 4, 2023
7 checks passed
@iloveeclipse
Copy link
Member

Master is closed, please revert.

@SarikaSinha
Copy link
Member

Yes, I thought it was for Java 21 branch. @gayanper Please create the PR for Beta branch.

SarikaSinha added a commit that referenced this pull request Sep 4, 2023
SarikaSinha added a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants