-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blank Javadoc #344
Remove blank Javadoc #344
Conversation
Be careful, some test resources are line dependent because the tests create line breakpoints. |
totally agreed. i tried to filter resources away. if i missed some i will remove those from commit |
2fb3ef3
to
bd74604
Compare
@laeubi tycho still does not build
|
@laeubi is eclipse-platform/eclipse.platform.releng.aggregator#1530 supposed to help here ? |
@akurtakov yes see https://github.com/eclipse-tycho/tycho/blob/c918e72c441d557fc82b6f691ddedc48ff3739ce/tycho-its/src/test/java/org/eclipse/tycho/test/apitools/ApiToolsTest.java#L128-L144 it is added as a (verified) test case there (Tycho 4.0.5 +). @jukzi build still uses "old" Tycho 4.0.4 as there is no new release yet. |
When will the build use a working Tycho version? Is there a workaround? |
4c6130c
to
788a34e
Compare
Manual rebase needed. |
This commit cleans up Javadoc that does not add information. It resolves ecj warnings: `Javadoc: Description expected after ...` It helps to prevent future empty javadoc by disabling missingJavaDoc warnings. This resolves `Javadoc: Missing ...` The modification is a result of regular expression search&replace: in files `*.java` `^[\s]*\*[\s]*(@return|@param[\s]*[^\s]+|@throws[\s]*[^\s]+)\R([\s]*\*[\s]*@|[\s]*\*/\R)` ->`$2` `^([\s]*\*[\s]*\R)([\s]*\*/\R)` ->`$2` `^[\S\t ]*/\*\*\R[\s]*\*/\R` ->`` in files `org.eclipse.jdt.core.prefs` `org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc(Comments|Tags)\=[^\s]*` ->`org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc$1\=ignore`
This commit cleans up Javadoc that does not add information. It resolves ecj warnings:
Javadoc: Description expected after ...
It helps to prevent future empty javadoc by disabling missingJavaDoc warnings. This resolves
Javadoc: Missing ...
The modification is a result of regular expression search&replace:
in files
*.java
^[\s]*\*[\s]*(@return|@param[\s]*[^\s]+|@throws[\s]*[^\s]+)\R([\s]*\*[\s]*@|[\s]*\*/\R)
->
$2
^([\s]*\*[\s]*\R)([\s]*\*/\R)
->
$2
^[\S\t]*/\*\*\R[\s]*\*/\R
->``
in files
org.eclipse.jdt.core.prefs
org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc(Comments|Tags)\=[^\s]*
->
org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc$1\=ignore