Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LongClassPathTests thread timeout fix. #517

Merged
merged 1 commit into from
Sep 30, 2024
Merged

LongClassPathTests thread timeout fix. #517

merged 1 commit into from
Sep 30, 2024

Conversation

SougandhS
Copy link
Contributor

@SougandhS SougandhS commented Sep 29, 2024 •
edited
Loading

What it does

Fix for #504
Increased timeout period

How to test

Author checklist

@SougandhS SougandhS force-pushed the LongClassPathTest_fix branch from 3d4ad94 to bfbb762 Compare September 29, 2024 02:51
@SougandhS
Copy link
Contributor Author

SougandhS commented Sep 30, 2024 •
edited
Loading

Hi @jukzi
can we try this ?
.Tested on my local.

jukzi
jukzi reviewed Sep 30, 2024
View reviewed changes
org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/launching/LongClassPathTests.java
boolean wasInterrupted = false;
do {
try {
Job.getJobManager().join(ResourcesPlugin.FAMILY_AUTO_BUILD, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before join() a job in tests that job should be woke up so that not so long time outs are needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@jukzi
Copy link
Contributor

jukzi commented Sep 30, 2024

can we try this ?

please call org.eclipse.core.internal.jobs.JobManager.wakeUp(Object family) before joining

@SougandhS
Copy link
Contributor Author

SougandhS commented Sep 30, 2024 •
edited
Loading

can we try this ?

please call org.eclipse.core.internal.jobs.JobManager.wakeUp(Object family) before joining
Tried the same, but still getting same issue.

image

@jukzi
Copy link
Contributor

jukzi commented Sep 30, 2024

Tried the same, but still getting same issue.

the argument must not be null but the families you will join

@SougandhS
Copy link
Contributor Author

SougandhS commented Sep 30, 2024 •
edited
Loading

Tried the same, but still getting same issue.

the argument must not be null but the families you will join

that too tried,
image

@jukzi
Copy link
Contributor

jukzi commented Sep 30, 2024

ok, then lets try this

@jukzi jukzi merged commit 69a4747 into eclipse-jdt:master Sep 30, 2024
10 checks passed
@SougandhS
Copy link
Contributor Author

ok, then lets try this

Okay 👍

@SougandhS
Copy link
Contributor Author

hi @jukzi
https://download.eclipse.org/eclipse/downloads/drops4/I20240930-1800/testresults/ep434I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17/org.eclipse.jdt.debug.tests.AutomatedSuite.txt

Now it is executing without any console errors.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi jukzi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SougandhS @jukzi