Duplicate mise's logic for finding Java installations #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiX
force-pushed
the
sync-mise-directory
branch
from
989ae7d to
0986a50
Compare
|
Overall, it looks good. Please rebase on top of master as it has conflicts. |
TobiX
force-pushed
the
sync-mise-directory
branch
from
0986a50 to
ab4fcdf
Compare
TobiX
force-pushed
the
sync-mise-directory
branch
from
ab4fcdf to
87d808a
Compare
|
tested on win, that detection still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This amends #493 by duplicating mise's logic on where to put installed Java versions (see https://github.com/jdx/mise/blob/c412b3295aa768980774126315da18a9db4a8349/src/env.rs#L48-L65), so we find them in the same location.
How to test
XDG_DATA_HOME,MISE_DATA_DIR) in your environmentmise install java@microsoft-17)Author checklist