Merge master to BETA_JAVA24 branch for JDT Debug #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a waiting time to ensure value is received prior invoking getHyperLink method as there is a possibility for throwing NPE Fixes : #559
The change in 3530050 replaced JDIDebugUIPlugin.getActiveWorkbenchShell() with PlatformUI.getWorkbench().getModalDialogShellProvider().getShell(), however later one behavior is undefined in API but implementation requires the caller to be in UI thread - which was not the case of the former API. => Move the code that acquires the modal shell into UI thread. Fixes #563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Author checklist