Jenkinsfile: longer history, less artifacts #576
Conversation
Keep more builds to get better statistics. But throw away artifacts after 99 days (~a quarter year). This should clean outdated PRs a bit. eclipse-platform/eclipse.platform.releng.aggregator#2653
|
@fredg02 I would like to hear from you before pushing such changes . |
|
cc @fredg02 |
|
i took the eclipse.jdt.debug repo first for a try because it has not as much traffic as other repos |
Jenkinsfile
Outdated
| @@ -1,7 +1,7 @@ | |||
| pipeline { | |||
| options { | |||
| timeout(time: 40, unit: 'MINUTES') | |||
| buildDiscarder(logRotator(numToKeepStr:'15')) | |||
| buildDiscarder(logRotator(numToKeepStr: '100', artifactNumToKeepStr: '15', artifactDaysToKeepStr: '99')) | |||
There was a problem hiding this comment.
So far, I did not see reliable behavior with artifactDaysToKeepStr, so I'd recommend avoiding it completely.
In this case, the combination of values also does not make much sense. If you only keep up to 15 builds with artifacts, and you build almost daily, artifacts will rarely get 99 days old. As discussed in eclipse-platform/eclipse.platform.releng.aggregator#2653, going with conditional values based on the branch is more robust.
I'd start with:
buildDiscarder(logRotator(numToKeepStr: ('master' == env.BRANCH_NAME) ? '50' : '5', artifactNumToKeepStr: '2')
And in a few weeks you can check back how often you wanted to access the artifacts of builds that are older than 2 builds. 🙂
There was a problem hiding this comment.
artifacts will rarely get 99 days old
look in JDT.core PRs, nobody cleans it:
the implementation looks solid
https://github.com/jenkinsci/jenkins/blob/5404f14af18155d62f819279a5debddcbff794c5/core/src/main/java/hudson/tasks/LogRotator.java#L213
There was a problem hiding this comment.
And in a few weeks you can check back how often you wanted to access the artifacts of builds that are older than 2 builds.
I know i did it in the past. Not often, but after almost every vacation because things got screwed up.
There was a problem hiding this comment.
This is because there are still open PRs for them like eclipse-jdt/eclipse.jdt.core#30 . If/when a PR is merged/closed it will be cleaned up.
There was a problem hiding this comment.
cancel "will be" and use "would be" - nobody in jdt.core does care.
There was a problem hiding this comment.
There was a problem hiding this comment.
the plan would be to apply such change to all our builds
There was a problem hiding this comment.
where is it configured for the I-Build?
There was a problem hiding this comment.
That's a serious issue and should be addressed. Keeping open PRs around for too long is both frustrating for the author of the PR, but also for committers and release engineers. |
come on, getting a first PR reviewed after several years (@vogella) is kinda cool. Those guys are just overwhelmed by work. |
Not sure what this refers to but I think this is very harmful behavior and not cool. |
|
sure, i tried to make a joke. its sad |
|
@iloveeclipse i also want to hear your opinion about the actual values, as you had increased them. |
|
merging to this repo to see if it works as intended |
Keep more builds to get better statistics for master and BETA branches.
But less builds for others (especially PRs).
eclipse-platform/eclipse.platform.releng.aggregator#2653