Incremental delete of duplicate interfaces (Delete ICleanUpCore) #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstryker
changed the title
robstryker
force-pushed
the
IncrementalDeleteOfDuplicateInterfacesPart2
branch
2 times, most recently
from
47d29c4 to
cef5bea
Compare
3 tasks
added 2 commits
February 7, 2024 16:23
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
IncrementalDeleteOfDuplicateInterfacesPart2
branch
2 times, most recently
from
d0010ca to
fe7f54f
Compare
Signed-off-by: Rob Stryker <stryker@redhat.com> Missed a file Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
IncrementalDeleteOfDuplicateInterfacesPart2
branch
from
fe7f54f to
1f28f80
Compare
…does Signed-off-by: Rob Stryker <stryker@redhat.com>
rgrunber
approved these changes
Feb 8, 2024
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/util/CleanUpCoreWrapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Stryker <stryker@redhat.com>
rgrunber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Removes internal interface ICleanupCore as a duplicate.
This PR depends on #1138 as it touches the same code
Why this is needed
While pushing code related to the completion subprocessors from jdt.ui to jdt.core.manipulations, one specific (and hefty) subprocessor, LocalCorrectionsSubProcessor, uses a lot of proposals that wrap
CleanUpobjects, using either theICleanUporICleanUpCoreinterfaces, as well as theAbstractCleanUporAbstractCleanUpCoreabstract classes.While identical interfaces are not much of a problem, having two parallel-but-slightly-different abstract classes leads to two parallel heirarchies, and clients can not simply extend both or support both very easily. While trying to untangle these specific issues, the myriad of other duplicate (and otherwise harmless) interfaces that are in the affected code also begin to add complexity to the solution.
With that in mind, removing the most unoffensive interfaces first becomes the safest course of action, while at the same time building our way up to tackling the larger parallel-heirarchy issue via small and manageable changes to the heirarchy as the situation becomes less cluttered.
How to test
Author checklist