Merge branch master into BETA_JAVA22 #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To centralize many deprecation warnings, since there is no replacement for SUPPRESS_SUBTASK_LABEL/PREPEND_MAIN_LABEL_TO_SUBTASK
This change adjusts TestSuiteElement to show the trace of a failed child, if that child is the only test case it ran and its dynamic. It also adjusts navigation to the failed line in this case - so that navigation goes to the failed line and not to the test method with the @testtemplate annotation. Fixes: #1021 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
When exporting JAR description files from the JarPackageWizard, the elements to be exported into the JAR file are currently stored in a non-deterministic order. This makes it particularly difficult to merge the description files in case they are put under version control. This change makes a JAR description file exported from the JarPackageWizard always list the exported elements in the same order by sorting them according to their names. It also adds an according regression test. Fixes #1024
Read the contents of the java file (test class) as a stream to avoid FileNotFoundException in nightly builds. Fixes #999
* Feature Proposal Make Static Refactoring Fixes #590 Introducing a new Refactoring called "Make Static", a tool that transforms instance methods into static ones in the context of Eclipse's Java Development Tools. This involves adjusting method invocations appropriately to maintain logical correctness. The refactoring supports both instance and static contexts, passing 'this' for invocations within instance methods and the relevant instance variable for invocations in other classes or static methods. Co-authored-by: Michael5601 <michael.bangas@vector.com> Co-authored-by: Jeff Johnston <jjohnstn@redhat.com>
- fixes #1023 - add new test to ExtractConstantTests1d7.java
To get rid of SubProgressMonitor deprecation warnings
* refactor method-ref fixes to be used in headless mode.
- fixes #1040 - don't perform convert to MessageFormat.format() or String.format() unless all string literals have NLS tags or none do - add new tests to AssistQuickFixTest
…1004) * Fix Bug 148012 - add quick fix to assign statement to local variable - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=148012 - use similar logic from QuickAssistProcessor in QuickFixProcessor when problem is IProblem.ParsingErrorInsertToComplete - add new test to QuickFixTest1d8 - don't add light-bulb for ParsingErrorInsertToComplete - fix QuickFixTest to have a version of collect completions that doesn't verify the light bulb marker
… (#1072) The "Make Static" refactoring currently adds a "this" parameter to the method in cases in which it is actually not necessary. This is particularly the case the body of the method to be refactored contains invocations of methods on a newly instantiated object. The according logic erroneously considers such a method invocation as a reason to add a parameter. With this fix, the identification of whether a parameter needs to be added to the method depends on whether the logic calculating an actual change to the method body is actually applied. An according regression test for the behavior is added. Fixes #1044
) * Avoid "overlapping text edits" in "Make Static" refactoring #1045 The "Make Static" refactoring currently produces overlapping text edits in case there are changes in the source code file containing the refactored method before and after that method. The reason is that the calls to the refactored method are wrapped into a single MultiTextEdit whose scope is then overlapping with the TextEdit for the refactored method itself. With this fix, the changes to callers of the refactored method are treated as individual TextEdits rather than one MultiTextEdit, so that none of the generated text edits have pairwise overlaps. An according regression test for the behavior is added. Fixes #1045
* Abstract out JavadocTagsSubProcessor for extension * Abstract out SerialVersionSubProcessor * Separate core from ui for UnInitializedFinalFieldSubProcessor * Allow all subprocessors to use IInvocationContextCore Signed-off-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Rob Stryker <stryker@redhat.com>
* disabled warning in test and example code * raised level to warning in production code * refactored code to get rid of all warnings Co-authored-by: Jörg Kubitz <jkubitz-eclipse@gmx.de>
* Push cleanup classes down to jdt.core.manipulations Signed-off-by: Rob Stryker <stryker@redhat.com>
In order to open a JAR file in multi-release mode the URL of the file must be suffixed with `#runtime`. Currently the `rsrc:` URL handler strips this fragment, which breaks multi-release JARs retrieved through the `rsrc:` protocol.
The other bundle might not be shutdown yet and would still want that key. Fixes #1093
…re.manipulation Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
- fixes #1123 - modify LocalCorrectionsSubProcessor.addInvalidVariableNameProposals() to recognize a duplicate constructor and instead of a rename suggest removal of duplicate constructor - add new test to LocalCorrectionsQuickFixTest.java
- fixes #915 - add wildcard support to ComparingOnCriteriaOperation.buildMethod() similar to what was added to buildField() - add to existing test case in CleanUpTest1d8 for comparator cleanup
* Split core/ui for ReorgCorrectionsSubProcessor * Separate core/ui in TypeMismatchSubProcessor * Split core/ui for ReturnTypeSubProcessor * Heavy work on UnresolvedElementsSubProcessor and linked classes * Update api filters Signed-off-by: Rob Stryker <stryker@redhat.com>
…h no return type (#1142) Signed-off-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Rob Stryker <stryker@redhat.com>
to use public API instead of type cast. Failing since I20240130-1800 Java nature and java project are now implemented as separate instances eclipse-jdt/eclipse.jdt.core#1916
CleanUpOptions @noextend is not intended to be subclassed by CLIENTS.
tested with System.gc() behind ExtractInterfaceTests1d8.testExtractInterfaceFromInterface2()
- add missing synchronization for getCurrentChange() which accesses fChange which is created in a synchronized method - potential fix for #1136
The type ThreadDeath has been deprecated since version 20 and marked for removal
The method createImage(ImageDescriptor) from the type ResourceManager is deprecated since version 3.31
* Move some core code into ReorgCorrectionBaseSubProcessor Signed-off-by: Rob Stryker <stryker@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1168
What it does
How to test
Author checklist