Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental delete of duplicate interfaces part5 #1183

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Incremental delete of duplicate interfaces part5 #1183

merged 2 commits into from
Mar 12, 2024

Conversation

robstryker
Copy link
Contributor

@robstryker robstryker commented Feb 9, 2024 •
edited
Loading

What it does

How to test

Author checklist

@robstryker robstryker marked this pull request as draft February 9, 2024 06:39
@robstryker robstryker force-pushed the IncrementalDeleteOfDuplicateInterfacesPart5 branch 3 times, most recently from 198768a to 91cecb0 Compare February 9, 2024 16:06
akurtakov
akurtakov reviewed Feb 12, 2024
View reviewed changes
...lipse.jdt.core.manipulation/common/org/eclipse/jdt/core/manipulation/CleanUpContextCore.java Outdated
*/
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is a clean/direct replacement please mark it as forRemoval=true, since="2024-03" so after 2026-03 release it can be deleted. Please apply elsewhere if you see fit.

@robstryker robstryker force-pushed the IncrementalDeleteOfDuplicateInterfacesPart5 branch from 91cecb0 to cd2243a Compare February 12, 2024 16:04
@robstryker
Copy link
Contributor Author

Build is green. Making one last commit to update the deprecated tags as requested.

@robstryker robstryker marked this pull request as ready for review February 12, 2024 17:05
@robstryker
Copy link
Contributor Author

So... this build was green, but apparently adding forRemoval=true adds a whole bunch new warnings with no obvious way to suppress them.

O_o

@akurtakov
Copy link
Contributor

So... this build was green, but apparently adding forRemoval=true adds a whole bunch new warnings with no obvious way to suppress them.

O_o

Are the deprecated methods still used?

@robstryker
Copy link
Contributor Author

I believe strongly the answer is no. They are not used. I would need to verify 100% for each class / method though.

@robstryker
Copy link
Contributor Author

Should i just be adding filters for all these?

@akurtakov akurtakov force-pushed the IncrementalDeleteOfDuplicateInterfacesPart5 branch 2 times, most recently from 2b03d8c to 267f581 Compare March 12, 2024 14:28
Rob Stryker added 2 commits March 12, 2024 11:39
Delete internal interface IMultiFixCore and ILinkedFixCore, plus small
66a38c7 
cleanup

Signed-off-by: Rob Stryker <stryker@redhat.com>
Delete many unnecessary wrapper CleanUp classes
239d5ed 
Compile error

Signed-off-by: Rob Stryker <stryker@redhat.com>

Cleanup

Signed-off-by: Rob Stryker <stryker@redhat.com>
@robstryker robstryker force-pushed the IncrementalDeleteOfDuplicateInterfacesPart5 branch from 267f581 to 239d5ed Compare March 12, 2024 15:39
@akurtakov akurtakov merged commit a288f60 into eclipse-jdt:master Mar 12, 2024
9 checks passed
@akurtakov
Copy link
Contributor

Merged without forRemoval=true as that would require some extra thought how to be done in less disruptive way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robstryker @akurtakov