Fix UI freeze due to extract to local computations #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes eclipse-jdt#1185 - don't run checkFinalConditions() from QuickAssistProcessor to see if extract to local variable proposals are valid - override the preview for extract to local variable and extract to local variable (replace all occurrences) so they just display a message instead of creating the change - fix ExtractTempRefactoring.checkFinalConditions() to recognize an invalid change in which case add an error status with a code that is RefactoringStatus.INFO - modify RefactoringCorrectionProposalCore to recognize an error refactoring status in which case create a dummy edit and if the INFO code is found, then also create a log entry to note that the extraction will not occur - fix AssistQuickFixTest tests proposal counts
jjohnstn
added
bug
- change error code to fatal - check if LinkedProposalModel not null before clearing - use RefactoringStatusCodes instead of making one up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes UI freezes in quick assist processor due to Extract to local variable proposal logic by replacing the preview with a message and also reverting the logic of #1176 to not show invalid proposals.
How to test
Hover over selections that might be extracted to local variable and note the time lag.
Author checklist