Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one if cleanup to watch for PatternInstanceof nodes #1201

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

jjohnstn
Copy link
Contributor

What it does

Fixes single if cleanup to handle case of pattern instanceof expressions.

How to test

See issue or new test.

Author checklist

@jjohnstn jjohnstn self-assigned this Feb 16, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Feb 16, 2024
@jjohnstn jjohnstn added this to the 4.32 M1 milestone Feb 16, 2024
- fixes eclipse-jdt#1200
- add new PatternInstanceof logic to
  OneIfRatherThanDuplicateBlocksThatFallThroughFixCore
- add new test to CleanUpTest16
@jjohnstn jjohnstn force-pushed the donotmergeinstanceofs branch from a1fc624 to 733c313 Compare March 9, 2024 03:50
@jjohnstn jjohnstn merged commit 16ca3ea into eclipse-jdt:master Mar 9, 2024
9 checks passed
@jjohnstn jjohnstn deleted the donotmergeinstanceofs branch March 9, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single if cleanup should not concatenate instanceofs that use pattern matching
1 participant