Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workaround for #945, as it causes problems in the JUnit view #1203

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

trancexpress
Copy link
Contributor

We revert the changes from:

#946
#1022

Since there are other regressions we see, such as showing the string comparison dialog not working.

What it does

How to test

Author checklist

@iloveeclipse
Copy link
Member

I've created #1216 to describe what is actually the problem we are trying to fix here (or revert changes that causing it).

I've also pushed #1217 that should address issues without reverting.

@iloveeclipse
Copy link
Member

As discussed, let merge this one for RC1, and try again with reverting revert & #1217 for 4.32 M1

@iloveeclipse iloveeclipse merged commit 22437d0 into eclipse-jdt:master Feb 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants