Fix lambda method ref generation to avoid ambiguous error #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify ConvertLambdaToMethodReferenceFixCore, LambdaExpressionsFixCore, and LambdaExpressionAndMethodRefFixCore when generating method refs to check if the method ref will be a method argument and if that method is overloaded, add a type cast to prevent an ambiguous error - add new tests to CleanUpTest1d8 and AssistQuickFixTest1d8 - fixes eclipse-jdt#1047
jjohnstn
force-pushed
the
lambdaambiguous
branch
from
24c251d to
49091d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes lambda cleanups and assists that create method refs to add a cast when needed to avoid a compiler error saying that the call is ambiguous.
How to test
See original issue and new tests.
Author checklist