Fix string concat to text block handling of redundant constructors #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix StringBuffer/StringBuilder to text block support when original code has one or more redundant constructors preceding the first append - fix StringBuffer/StringBuilder look-ahead to next constructor statement logic so it doesn't change next constructor to VariableDeclarationStatement if the initial declaration never gets removed (i.e. first concenatation was invalid for conversion) - add new test scenarios to CleanUpTest15 - fixes eclipse-jdt#1238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes more edge-case scenarios discovered by converting test suite to use text blocks.
How to test
See issue or new test scenarios.
Author checklist