Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logic to cast lambda for wildcard argument #1674

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jjohnstn
Copy link
Contributor

What it does

Adds a cast when needed to the lambda if it is a method argument where the argument is defined as a wild card type and
the bounds of the type and the class instance creation type arguments aren't sub-type compatible.

How to test

See issue or new tests.

Author checklist

- modify LambdaExressionsFixCore to add a cast if the lambda will
  end up as an argument that is supposed to be a wildcard type and
  the bound is not compatible with the initial class instance
  creation type argument
- add new tests to CleanUpTest1d8
- fixes eclipse-jdt#1535
@jjohnstn jjohnstn self-assigned this Sep 26, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Sep 26, 2024
@jjohnstn jjohnstn added this to the 4.34 M1 milestone Sep 26, 2024
@jjohnstn jjohnstn merged commit 486989e into eclipse-jdt:master Sep 26, 2024
9 checks passed
@jjohnstn jjohnstn deleted the lambdacast branch September 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Up produces compile error for JUnit5 assertion (possibly generics compile issue)
1 participant