Fixdeprecations

[carstenartur]

What it does

Fix some deprecations by doing what the deprecation message suggests.

How to test

Ideally nothing should change in behavior.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[carstenartur]

Hi @jjohnstn , when you find the time could you have a look? While we reduced the amount of warnings with the last patch by half we are still one of the projects with the highest amount of deprecations. If you are unsure about one or another change feel free to leave it out this time.

[jjohnstn]

Hi @carstenartur Will look at it today.

[akurtakov]

Would you guys please the failures at check https://download.eclipse.org/eclipse/downloads/drops4/I20241020-0600/testresults/html/org.eclipse.pde.ui.tests_ep434I-unit-cen64-gtk3-java23_linux.gtk.x86_64_23.html ? They started to appear after this change and I haven't noticed any other change in this area.

[carstenartur]

Just from looking at the code
right now I cannot see where the issue is. Can someone rollback and maybe next Weekend I can have a look?

[akurtakov]

Looks like it has different cause as explained in eclipse-jdt/eclipse.jdt.core#3125 (comment)