Bugfix for #1803: [Externalize Strings] IndexOutOfBoundsException. #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
reviewed
Nov 25, 2024
| @@ -37,76 +37,90 @@ public class NLSHintStripQuotesTest { | |||
| @Rule | |||
| public Java15ProjectTestSetup pts15= new Java15ProjectTestSetup(); | |||
|
|
|||
| private IJavaProject javaProject; | |||
| private IJavaProject javaProject15; | |||
| private IJavaProject javaProject; | |||
There was a problem hiding this comment.
please avoid touching so many line with whitespace changes as it disturbs the git history
There was a problem hiding this comment.
I have restored the old (wrong) whitespaces.
jukzi
force-pushed
the
1803-externalize-strings-IndexOutOfBoundsException
branch
from
2dd8b6d to
b85953c
Compare
|
thanks for contribution. i manually verified the added test failed before the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #1803.
How to test
See "Steps to reproduce" in the bug report #1803. With this fix the NSL dialog should open as usually.
Author checklist